Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse patch server #51 #60

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

Ph0tonic
Copy link
Contributor

@Ph0tonic Ph0tonic commented Jan 9, 2024

Since jupyterhub/jupyterhub#3810, the fix brought by #51 on master but not yet release, breaks KubeSpawner. The spawner at least doesn't start without removing this patch, using 1.0.1 works but using the version on master fails.

See #50 (comment)

To test wrapSpawner, I used the KubeSpawner inside z2jh with the following configuration.

c.ProfilesSpawner.profiles = [
    ('Kube', 'kubespawner', 'kubespawner.KubeSpawner', {
        'ip':'0.0.0.0', 'port': 0, 'cmd': None, 'path': None, 'environment': {}, 'env_keep': []}),
    # Other spawner here
]

I haven't tested with BatchSpawner yet but this is my next step, I will report any test progress here.

Fixes #54

@Ph0tonic
Copy link
Contributor Author

So I managed to test this patch with batchSpawner and it's working fine 👍

Any feedback is welcome 🎉

@minrk minrk merged commit c337112 into jupyterhub:master Mar 21, 2024
Copy link

welcome bot commented Mar 21, 2024

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@minrk
Copy link
Member

minrk commented Mar 21, 2024

Thanks for the fix! Sorry for taking forever.

@minrk minrk mentioned this pull request Mar 21, 2024
@Ph0tonic
Copy link
Contributor Author

Ph0tonic commented Mar 21, 2024

Great, you are welcome @minrk !
If you could also have a look at #59, #61 and #62 it would be awesome !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconsidering manual server linkage
2 participants