Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve mobile user experience (payment-processor) #1666

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Vaibhav91one
Copy link

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Mobile Responsive for connectors

Motivation and Context

How did you test it?

Locally

PR-2 Fix 1
PR-2 Fix 2
PR-2 Fix

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@Vaibhav91one Vaibhav91one requested a review from a team as a code owner October 28, 2024 19:16
Copy link

semanticdiff-com bot commented Oct 28, 2024

Review changes with  SemanticDiff

@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Oct 28, 2024
@PritishBudhiraja PritishBudhiraja changed the title UI/mobile responsive payment processor enhancement(payment-processor): improve mobile user experience Oct 29, 2024
@Riddhiagrawal001
Copy link
Contributor

Hi @Vaibhav91one , Can you attach a working video of the changes

@Vaibhav91one
Copy link
Author

Vaibhav91one commented Oct 29, 2024

Hi @Vaibhav91one , Can you attach a working video of the changes

Hmm, I have attached images of the changes and just to clarify video of UI right. @Riddhiagrawal001

@Riddhiagrawal001
Copy link
Contributor

Yes @Vaibhav91one , video of the UI of the changes

@Vaibhav91one
Copy link
Author

Vaibhav91one commented Oct 29, 2024

Yes @Vaibhav91one , video of the UI of the changes

Will do. Also, Please ignore the changes in HomeUtils, that is for another issue.

@Vaibhav91one
Copy link
Author

Yes @Vaibhav91one , video of the UI of the changes

Will do. Also, Please ignore the changes in HomeUtils, that is for another issue.

@Riddhiagrawal001 PFA, the video for the fixes.

payment.Fix-3.mp4
payment.Fix-2.mp4
paymet.fix-1.mp4

@Riddhiagrawal001 Riddhiagrawal001 changed the title enhancement(payment-processor): improve mobile user experience refactor(payment-processor): improve mobile user experience Oct 30, 2024
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Oct 30, 2024
@kanikabansal-juspay kanikabansal-juspay changed the title refactor(payment-processor): improve mobile user experience refactor: improve mobile user experience (payment-processor) Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants