feat: enable payment methods cloning to another profile of same merchant #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
gitanjli525
added
S-waiting-on-review
added 6 commits
December 19, 2024 15:56
sagarnaikjuspay
previously approved these changes
Dec 24, 2024
config/config.toml
Outdated
| @@ -54,6 +54,7 @@ x_feature_route=false | |||
| tenant_user=false | |||
| dev_click_to_pay=false | |||
| dev_recon_v2_product=false | |||
| clone_payment_methods=false | |||
There was a problem hiding this comment.
updated @JeevaRamu0104
…center into clone-payment-methods-feature
| @@ -94,6 +100,21 @@ let make = (~setCurrentStep, ~connector, ~setInitialValues, ~initialValues, ~isU | |||
| Nullable.null | |||
| } | |||
|
|
|||
| React.useEffect(() => { | |||
| if paymentMethodsClone->Array.length > 0 { | |||
There was a problem hiding this comment.
please recheck this condition
| let json = await fetchDetails(connectorUrl) | ||
| setInitialValues(_ => json) | ||
| } catch { | ||
| | _ => Exn.raiseError("Something went wrong") |
There was a problem hiding this comment.
what happens if the exception is throwed
There was a problem hiding this comment.
updated and showed a toast error in such case
| @@ -1560,6 +1560,26 @@ let defaultSelectAllCards = ( | |||
| } | |||
| } | |||
|
|
|||
| let setConnectorPaymentMethods = async (initialValues, setPaymentMethods, setMetaData) => { | |||
There was a problem hiding this comment.
Please write this function inside the clone module itself
| } | ||
| } | ||
|
|
||
| React.useEffect(() => { |
There was a problem hiding this comment.
do we need this useEffect can we write everything inside the getConnectorDetails function itself
| None | ||
| }, [initialValues]) | ||
|
|
||
| React.useEffect(() => { |
| @@ -152,13 +157,15 @@ let make = () => { | |||
| let customStyle = "text-blue-500 bg-white dark:bg-black hover:bg-jp-gray-100 text-nowrap w-full" | |||
| let addItemBtnStyle = "border border-t-0 w-full" | |||
| let customScrollStyle = "max-h-72 overflow-scroll px-1 pt-1 border border-b-0" | |||
| let dropdownContainerStyle = "rounded-md border border-1 w-[15rem]" | |||
| let dropdownContainerStyle = "rounded-md border border-1 w-[14rem] max-w-[20rem]" | |||
There was a problem hiding this comment.
please raise this as a separate PR
JeevaRamu0104
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
https://github.com/user-attachments/assets/0e7d786a-a922-48e0-b726-b9e6479ed1a7
Motivation and Context
How did you test it?
Where to test it?
Checklist
npm run re:build