Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added profile name validation #2128

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: added profile name validation #2128

wants to merge 3 commits into from
+2 −0

Conversation

gitanjli525
Copy link
Contributor

@gitanjli525 gitanjli525 commented Jan 24, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • changes contain preventing current profile name to be submitted in edit profile name

image
image

Motivation and Context

How did you test it?

  • go to business profile
  • edit profile name

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@gitanjli525 gitanjli525 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed core Status: issues related to core labels Jan 24, 2025
@gitanjli525 gitanjli525 self-assigned this Jan 24, 2025
@gitanjli525 gitanjli525 requested a review from a team as a code owner January 24, 2025 06:57
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@gitanjli525 gitanjli525 linked an issue Jan 24, 2025 that may be closed by this pull request
[BUG] Update business profile name should not accept empty and previous name #1505
Open
@gitanjli525 gitanjli525 enabled auto-merge January 27, 2025 08:25
@gitanjli525 gitanjli525 added this pull request to the merge queue Jan 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagarnaikjuspay sagarnaikjuspay sagarnaikjuspay approved these changes

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

Assignees

@gitanjli525 gitanjli525

Labels
core Status: issues related to core S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Update business profile name should not accept empty and previous name
3 participants
@gitanjli525 @JeevaRamu0104 @sagarnaikjuspay