-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): add postman collection and newman github CI runner #42
base: main
Are you sure you want to change the base?
Conversation
c4 c5 c6 c7 c8 c9 c10 c11 c12 added newman ci checks w postman c13 c14 c15 collection constructed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vkhinvasara, first of all, thank you showing interest in contributing to the encryption service!
It would be great if you could address the below short comings! You're close to getting this PR merged!
One additional thing that I would recommend you is to run the test in CI and post the screenshot of the checks running successfully in the PR description.
… and decryption along with neccesary CI changes
@pixincreate I've made the changes you've suggested. Please let me know if I've missed anything. Thank you for your cooperation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: redundant empty lines.
other than that, lgtm!
initial template 2 initial workflow check 3 c4 c5 c6 c7 c8 c9 c10 c11 c12 added newman ci checks w postman c13 c14 c15 collection constructed Basic tests added final event checks bump version to 0.1.0 and update Postman requests for data encryption and decryption along with neccesary CI changes Final changes minor tweaks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please run it once again, and update the PR description.
looks good to me!
Introduce a new GitHub Actions workflow for running Postman tests, along with the necessary configurations and basic test cases for the encryption utility. Reference to issue #34.