-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(currency_conversion): re frame the currency_conversion crate to make api calls on background thread #6906
Open
prajjwalkumar17
wants to merge
15
commits into
main
Choose a base branch
from
reframe_forex
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files
|
prajjwalkumar17
added
A-currency-conversion
Area: Currency Conversion
C-refactor
Category: Refactor
labels
Jan 3, 2025
prajjwalkumar17
requested review from
SanchithHegde,
ShivanshMathurJuspay and
Chethan-rao
January 3, 2025 12:02
Chethan-rao
requested changes
Jan 6, 2025
Chethan-rao
requested changes
Jan 6, 2025
Chethan-rao
requested changes
Jan 6, 2025
Chethan-rao
requested changes
Jan 6, 2025
Chethan-rao
requested changes
Jan 6, 2025
Chethan-rao
requested changes
Jan 6, 2025
Chethan-rao
reviewed
Jan 6, 2025
Chethan-rao
reviewed
Jan 6, 2025
) -> CustomResult<FxExchangeRatesCacheEntry, ForexCacheError> { | ||
if let Some(local_rates) = retrieve_forex_from_local().await { | ||
if local_rates.is_expired(call_delay) { | ||
// expired local data | ||
handler_local_expired(state, call_delay, local_rates).await | ||
logger::debug!("forex_log: Forex stored in cache is expired"); | ||
successive_fetch_and_save_forex(state, Some(local_rates)).await |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename this method as it is not successive anymore
prajjwalkumar17
force-pushed
the
reframe_forex
branch
from
January 6, 2025 11:56
2c2a057
to
a1d0992
Compare
Chethan-rao
reviewed
Jan 6, 2025
Chethan-rao
approved these changes
Jan 9, 2025
prajjwalkumar17
changed the title
refactor(currency_conversion): re frame the crate to make api calls on background thread
refactor(currency_conversion): re frame the currency_conversion crate to make api calls on background thread
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Due to redis lock being held for a long time, which made the forex api-calls synchronous, we had to re-frame the way how things were being operated for forex rates fetch, The changes includes:
Additional Changes
Motivation and Context
How did you test it?
Full response:
Checklist
cargo +nightly fmt --all
cargo clippy