fix: disallow trailing . in key name (#77)

* fix: disallow trailing . in key name

* fix: upgrade aws cli to version 2

.editorconfig

@@ -5,7 +5,7 @@ root = true
 charset = utf-8
 indent_style = space
 indent_size = 4
-insert_final_newline = false
+insert_final_newline = true
 trim_trailing_whitespace = true
 
 [*.md]

crates/context_aware_config/src/api/default_config/handlers.rs

@@ -50,6 +50,14 @@ async fn create(
     let req = request.into_inner();
     let key = key.into_inner();
 
+    if key.ends_with(".") {
+        log::error!("configuration key {key} cannot end with a '.' character.");
+        return Err(bad_argument!(
+            "Configuration key cannot end with a '.' character. \
+            Please remove the trailing '.' in the key name."
+        ));
+    }
+
     if req.value.is_none() && req.schema.is_none() && req.function_name.is_none() {
         log::error!("No data provided in the request body for {key}");
         return Err(bad_argument!("Please provide data in the request body."));

flake.nix

@@ -36,7 +36,7 @@
             gnumake
             # Why do we need this?
             stdenv.cc
-            awscli
+            awscli2
             jq
             nodejs_18
             nixpkgs-fmt

makefile

@@ -50,7 +50,7 @@ tenant:
 	grep 'DATABASE_URL=' .env | sed -e 's/DATABASE_URL=//' | xargs ./scripts/create-tenant.sh -t $(TENANT) -d
 
 validate-aws-connection:
-	aws --endpoint-url=http://$(DOCKER_DNS):4566 --region=ap-south-1 sts get-caller-identity
+	aws --no-cli-pager --endpoint-url=http://$(DOCKER_DNS):4566 --region=ap-south-1 sts get-caller-identity
 
 validate-psql-connection:
 	pg_isready -h $(DOCKER_DNS) -p 5432

postman/cac/Default Config/Default-Config Add Key Failure/.event.meta.json

@@ -0,0 +1,5 @@
+{
+  "eventOrder": [
+    "event.test.js"
+  ]
+}

postman/cac/Default Config/Default-Config Add Key Failure/event.test.js

@@ -0,0 +1,3 @@
+pm.test("400 check", function () {
+    pm.response.to.have.status(400);
+});

postman/cac/Default Config/Default-Config Add Key Failure/request.json

@@ -0,0 +1,45 @@
+{
+  "method": "PUT",
+  "header": [
+    {
+      "key": "Authorization",
+      "value": "Bearer {{token}}",
+      "type": "text"
+    },
+    {
+      "key": "Content-Type",
+      "value": "application/json",
+      "type": "text"
+    },
+    {
+        "key": "x-tenant",
+        "value": "test",
+        "type": "default"
+    }
+  ],
+  "body": {
+    "mode": "raw",
+    "options": {
+      "raw": {
+        "language": "json"
+      }
+    },
+    "raw_json_formatted": {
+      "value": "value1",
+      "schema": {
+        "type": "string",
+        "pattern": ".*"
+      }
+    }
+  },
+  "url": {
+    "raw": "{{host}}/default-config/key.",
+    "host": [
+      "{{host}}"
+    ],
+    "path": [
+      "default-config",
+      "key."
+    ]
+  }
+}

postman/cac/Default Config/Default-Config Add Key Failure/response.json

@@ -0,0 +1 @@
+[]