add snapshot while context , default configs updates #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratikmishra356
force-pushed
the
snapshot-api-changes
branch
10 times, most recently
from
b6410a5 to
b7c93df
Compare
mahatoankitkumar
requested changes
Apr 29, 2024
crates/context_aware_config/migrations/2024-04-22-122806_config_verions/up.sql
Outdated
Show resolved
Hide resolved
mahatoankitkumar
requested changes
Apr 29, 2024
mahatoankitkumar
requested changes
Apr 29, 2024
pratikmishra356
force-pushed
the
snapshot-api-changes
branch
from
b7c93df to
2b3bd23
Compare
Datron
requested changes
Apr 30, 2024
crates/context_aware_config/migrations/2024-04-22-122806_config_verions/up.sql
Outdated
Show resolved
Hide resolved
|
Can we squash all commits into one? |
mahatoankitkumar
requested changes
Apr 30, 2024
pratikmishra356
force-pushed
the
snapshot-api-changes
branch
from
2b3bd23 to
7c77fe5
Compare
pratikmishra356
force-pushed
the
snapshot-api-changes
branch
4 times, most recently
from
70fabc6 to
5a0dcbd
Compare
pratikmishra356
force-pushed
the
snapshot-api-changes
branch
2 times, most recently
from
800bbe4 to
0699ef5
Compare
sauraww
requested changes
May 28, 2024
pratikmishra356
force-pushed
the
snapshot-api-changes
branch
7 times, most recently
from
9eaebd2 to
779e975
Compare
Datron
requested changes
May 30, 2024
crates/context_aware_config/migrations/2024-04-22-122806_config_verions/up.sql
Show resolved
Hide resolved
ShubhranshuSanjeev
requested changes
May 30, 2024
crates/experimentation_platform/src/api/experiments/handlers.rs
Outdated
Show resolved
Hide resolved
pratikmishra356
force-pushed
the
snapshot-api-changes
branch
2 times, most recently
from
3b7cfa4 to
8e8ce3f
Compare
Datron
approved these changes
May 31, 2024
pratikmishra356
force-pushed
the
snapshot-api-changes
branch
2 times, most recently
from
c3a670c to
f6b4cf2
Compare
pratikmishra356
force-pushed
the
snapshot-api-changes
branch
4 times, most recently
from
8277168 to
a9b5343
Compare
mahatoankitkumar
approved these changes
Jun 3, 2024
ShubhranshuSanjeev
approved these changes
Jun 3, 2024
sauraww
approved these changes
Jun 3, 2024
pratikmishra356
force-pushed
the
snapshot-api-changes
branch
from
a9b5343 to
2e1f755
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Record for config's history after every cac_config changes,
we also encountered problem regarding generating snowflake_id, we were not dropping the acquired mutex lock,
and when generating another snowflake_id , it gets stuck in deadlock kind of situation
Solution
Created config_versions table which will store the config's snapshot after every updates which affect the configs.
Fetch contexts and default_configs and insert into config_Versions table after any updates within the same transaction.
we are explicitly dropping acquired lock after snowflake_id generation
Also accepting tags parameters in every update request so that user can tag every versions
Environment variable changes
NA
Pre-deployment activity
Create db changes
Post-deployment activity
NA
API changes
get_config apis we will now provide priority inside context objects
adding optional tags field in every context, default_config and experiments updates
accepting version queryparam in every get_config apis
Possible Issues in the future
NA