fix: webhook ui failure handling #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShubhranshuSanjeev
requested changes
Jan 21, 2025
| @@ -429,7 +429,7 @@ where | |||
| enqueue_alert(error_msg.clone(), AlertType::Error, 5000); | |||
| return Err(error_msg); | |||
| } | |||
| if status.is_server_error() { | |||
| if status.is_server_error() && status != 512 { | |||
There was a problem hiding this comment.
Why are we ignoring this very specific error code?
There was a problem hiding this comment.
This is a custom error code sent by the webhook.
When the webhook fails, the steps involving the experiment and CAC are already completed. Users receive a false signal that the experiment wasn't created, prompting them to attempt creation multiple times, potentially leading to duplicate experiments.
ShubhranshuSanjeev
approved these changes
Jan 21, 2025
ayushjain17
approved these changes
Jan 21, 2025
|
why is this pointed to main ? |
saas might take a while to go to prod |
Datron
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Webhook failures in frontend not handled properly
Solution
added a condition to ignore the 512 status code