feat: reducing context tool #44
Conversation
Sauravcv98
force-pushed
the
Reduce-context-tool
branch
3 times, most recently
from
207590e to
3da0a55
Compare
| res | ||
| } | ||
|
|
||
| fn construct_new_payload(req_payload: &Map<String, Value>) -> web::Json<PutReq> { |
There was a problem hiding this comment.
Why not take a mutable cloned reference as an argument and skip the first line?
There was a problem hiding this comment.
Hey actually, i'll have to do the same where i'm calling also
Like i would have to clone it over there and send it.
| Vec::new(); | ||
|
|
||
| for (key, val) in og_overrides.clone() { | ||
| match val { |
There was a problem hiding this comment.
can you just do:
| match val { | |
| val.as_object().unwrap_or(()) |
There was a problem hiding this comment.
Hey, I would have to give a default value for unwrap_or, so i went with this
Sauravcv98
force-pushed
the
Reduce-context-tool
branch
2 times, most recently
from
d317257 to
d1840fb
Compare
Sauravcv98
force-pushed
the
Reduce-context-tool
branch
3 times, most recently
from
4c4a52c to
d09d43c
Compare
Sauravcv98
force-pushed
the
Reduce-context-tool
branch
from
d09d43c to
75d6123
Compare
| } | ||
|
|
||
| #[put("/reduce")] | ||
| async fn reduce_context( |
There was a problem hiding this comment.
@Sauravcv98 is there any specific reason we kept this api under config and not context ?
There was a problem hiding this comment.
Hey this actually reduces the entire Config, even the response of this is of type Config
There was a problem hiding this comment.
ok make sense ,
can you rename the function to reduce_config ?
There was a problem hiding this comment.
Yeah true, was thinking the same
Will rename this to reduce_config
Problem
Too many Context duplicates, where some contexts are a subContext of other one's with the same overrides, so the parent one is not even required
Solution
Removing contexts if we find any one subcontext with the same override key, then we remove the override key from the parent context, now if all of the override keys are removed from the parent context then we can remove the entire context, so we just delete it.