chore: add PR testing workflows #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datron
force-pushed
the
workflows
branch
15 times, most recently
from
abfef8e to
7e63ea0
Compare
Datron
force-pushed
the
workflows
branch
2 times, most recently
from
497a501 to
4b9307f
Compare
| let db_password_raw = kms::decrypt(kms_client, "DB_PASSWORD").await; | ||
| let db_password = encode(db_password_raw.as_str()).to_string(); | ||
| let app_env: String = get_from_env_or_default("APP_ENV", "TEST".into()); | ||
| let db_password: String = if app_env.as_str() == "TEST" { |
There was a problem hiding this comment.
any reason to deviate from the KMS setup for testing?
There was a problem hiding this comment.
Why do we do this in development environments? Makes easy setups complex. So I wanted to add in an exception for this. Also, KMS encryption is only for juspay, we should remove this from this repo
There was a problem hiding this comment.
Sure, make sense.
| make superposition -e DOCKER_DNS=$(DOCKER_DNS) | ||
|
|
||
| ci-test: cleanup ci-setup |
There was a problem hiding this comment.
why remove cleanup from here?
There was a problem hiding this comment.
We don't need docker cleanup anymore, github actions automatically cleans up containers
| @@ -1,4 +1,4 @@ | |||
| DATABASE_URL=postgres://postgres:docker@dockerdns:5432/config?sslmode=disable | |||
| DATABASE_URL=postgres://postgres:docker@localhost:5432/config?sslmode=disable | |||
There was a problem hiding this comment.
changing from dockerdns to localhost as we won't have docker-in-docker, since we are moving away from Jenkins?
Datron
force-pushed
the
workflows
branch
11 times, most recently
from
68aac6f to
fdb6177
Compare
Datron
force-pushed
the
workflows
branch
4 times, most recently
from
48777d4 to
228adb3
Compare
Datron
requested review from
knutties,
pratikmishra356,
Sauravcv98,
sauraww and
mahatoankitkumar
mahatoankitkumar
approved these changes
Apr 22, 2024
pratikmishra356
approved these changes
Apr 22, 2024
ShubhranshuSanjeev
approved these changes
Apr 22, 2024
Datron
added a commit
that referenced
this pull request
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Superposition doesn't have testing for every PR setup
Solution
add that using github actions