feat: 💥 change tag api to batch #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
su-chang
reviewed
Feb 23, 2024
proto/wechaty/puppet/tag.proto
Outdated
| string tag_name = 1; | ||
| string tag_group_id = 2; | ||
| string tag_group_id = 2; | ||
| repeated string tag_name_list = 3; |
There was a problem hiding this comment.
这个tag_name_list应该会被自动再加一次list，可以考虑去掉，下面两个同理。
There was a problem hiding this comment.
确实如此，现有定义中还有一些名称是有点小问题的
xxIds => xxIdsList
su-chang
reviewed
Feb 23, 2024
su-chang
reviewed
Feb 23, 2024
proto/wechaty/puppet/tag.proto
Outdated
| message TagTagAddRequest { | ||
| string tag_name = 1; | ||
| string tag_group_id = 2; | ||
| string tag_group_id = 2; |
There was a problem hiding this comment.
因为改成了数组，虽然 proto 解析不会出问题，但生成的 ts 会与以前不兼容。
su-chang
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
References to other Issues or PRs
Have you read the Contributing Guidelines?
Brief description of what is fixed or changed
Other comments