Skip to content

Commit

Permalink
ArmPkg: Fix various typos
Browse files Browse the repository at this point in the history
Fix various typos in ArmPkg.

Signed-off-by: Coeur <[email protected]>
Reviewed-by: Leif Lindholm <[email protected]>
  • Loading branch information
Coeur authored and Leif Lindholm committed Jul 4, 2019
1 parent 080981d commit ff5fef1
Show file tree
Hide file tree
Showing 31 changed files with 62 additions and 62 deletions.
2 changes: 1 addition & 1 deletion ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.c
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ CpuIoCheckParameter (
//
// Since MAX_ADDRESS can be the maximum integer value supported by the CPU and Count
// can also be the maximum integer value supported by the CPU, this range
// check must be adjusted to avoid all oveflow conditions.
// check must be adjusted to avoid all overflow conditions.
//
// The following form of the range check is equivalent but assumes that
// MAX_ADDRESS and MAX_IO_PORT_ADDRESS are of the form (2^n - 1).
Expand Down
2 changes: 1 addition & 1 deletion ArmPkg/Drivers/CpuDxe/AArch64/Mmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ GetMemoryRegionRec (
BlockEntry++;
} else if (EntryType == BlockEntryType) {
// We have found the BlockEntry attached to the address. We save its start address (the start
// address might be before the 'BaseAdress') and attributes
// address might be before the 'BaseAddress') and attributes
*BaseAddress = *BaseAddress & ~(TT_ADDRESS_AT_LEVEL(TableLevel) - 1);
*RegionLength = 0;
*RegionAttributes = *BlockEntry & TT_ATTRIBUTES_MASK;
Expand Down
2 changes: 1 addition & 1 deletion ArmPkg/Drivers/CpuDxe/Arm/Mmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ SyncCacheConfig (
EFI_GCD_MEMORY_SPACE_DESCRIPTOR *MemorySpaceMap;


DEBUG ((EFI_D_PAGE, "SyncCacheConfig()\n"));
DEBUG ((DEBUG_PAGE, "SyncCacheConfig()\n"));

// This code assumes MMU is enabled and filed with section translations
ASSERT (ArmMmuEnabled ());
Expand Down
2 changes: 1 addition & 1 deletion ArmPkg/Drivers/CpuDxe/CpuMmuCommon.c
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ CpuSetMemoryAttributes (

if ((BaseAddress & (SIZE_4KB - 1)) != 0) {
// Minimum granularity is SIZE_4KB (4KB on ARM)
DEBUG ((EFI_D_PAGE, "CpuSetMemoryAttributes(%lx, %lx, %lx): Minimum ganularity is SIZE_4KB\n", BaseAddress, Length, EfiAttributes));
DEBUG ((DEBUG_PAGE, "CpuSetMemoryAttributes(%lx, %lx, %lx): Minimum granularity is SIZE_4KB\n", BaseAddress, Length, EfiAttributes));
return EFI_UNSUPPORTED;
}

Expand Down
4 changes: 2 additions & 2 deletions ArmPkg/Drivers/CpuDxe/CpuMpCore.c
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ PublishArmProcessorTable (
// Allocate Runtime memory for ARM processor table
ArmProcessorTable = (ARM_PROCESSOR_TABLE*)AllocateRuntimePool(sizeof(ARM_PROCESSOR_TABLE));

// Check if the memory allocation is succesful or not
// Check if the memory allocation is successful or not
ASSERT(NULL != ArmProcessorTable);

// Set ARM processor table to default values
Expand All @@ -81,7 +81,7 @@ PublishArmProcessorTable (
ArmProcessorTable->ArmCpus = (ARM_CORE_INFO*)AllocateRuntimePool (
ArmProcessorTable->NumberOfEntries * sizeof(ARM_CORE_INFO));

// Check if the memory allocation is succesful or not
// Check if the memory allocation is successful or not
ASSERT(NULL != ArmProcessorTable->ArmCpus);

// Copy ARM Processor Table data from HOB list to newly allocated memory
Expand Down
2 changes: 1 addition & 1 deletion ArmPkg/Drivers/CpuDxe/Exception.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ InitializeExceptions (
VectorInfo = VectorInfoList;
}

// intialize the CpuExceptionHandlerLib so we take over the exception vector table from the DXE Core
// initialize the CpuExceptionHandlerLib so we take over the exception vector table from the DXE Core
InitializeCpuExceptionHandlers(VectorInfo);

Status = EFI_SUCCESS;
Expand Down
2 changes: 1 addition & 1 deletion ArmPkg/Drivers/CpuPei/CpuPei.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Module Name:
//
#include <PiPei.h>
//
// The protocols, PPI and GUID defintions for this module
// The protocols, PPI and GUID definitions for this module
//
#include <Ppi/ArmMpCoreInfo.h>

Expand Down
2 changes: 1 addition & 1 deletion ArmPkg/Drivers/TimerDxe/TimerDxe.c
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ TimerInitialize (
UINT32 TimerHypIntrNum;

if (ArmIsArchTimerImplemented () == 0) {
DEBUG ((EFI_D_ERROR, "ARM Architectural Timer is not available in the CPU, hence cann't use this Driver \n"));
DEBUG ((DEBUG_ERROR, "ARM Architectural Timer is not available in the CPU, hence can't use this Driver \n"));
ASSERT (0);
}

Expand Down
2 changes: 1 addition & 1 deletion ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c
Original file line number Diff line number Diff line change
Expand Up @@ -691,7 +691,7 @@ FileGetPosition (
@param[in] Position The byte position from the start of the file to set.
@retval EFI_SUCCESS The position was set.
@retval EFI_DEVICE_ERROR The semi-hosting positionning operation failed.
@retval EFI_DEVICE_ERROR The semi-hosting positioning operation failed.
@retval EFI_UNSUPPORTED The seek request for nonzero is not valid on open
directories.
@retval EFI_INVALID_PARAMETER The parameter "This" is NULL.
Expand Down
2 changes: 1 addition & 1 deletion ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.h
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ FileGetPosition (
@param[in] Position The byte position from the start of the file to set.
@retval EFI_SUCCESS The position was set.
@retval EFI_DEVICE_ERROR The semi-hosting positionning operation failed.
@retval EFI_DEVICE_ERROR The semi-hosting positioning operation failed.
@retval EFI_UNSUPPORTED The seek request for nonzero is not valid on open
directories.
Expand Down
4 changes: 2 additions & 2 deletions ArmPkg/Include/Library/ArmDisassemblerLib.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
#define __ARM_DISASSEBLER_LIB_H__

/**
Place a dissasembly of of **OpCodePtr into buffer, and update OpCodePtr to
point to next instructin.
Place a disassembly of **OpCodePtr into buffer, and update OpCodePtr to
point to next instruction.
We cheat and only decode instructions that access
memory. If the instruction is not found we dump the instruction in hex.
Expand Down
2 changes: 1 addition & 1 deletion ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.c
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ MicroSecondDelay (
@param NanoSeconds The minimum number of nanoseconds to delay.
@return The value of NanoSeconds inputed.
@return The value of NanoSeconds inputted.
**/
UINTN
Expand Down
2 changes: 1 addition & 1 deletion ArmPkg/Library/ArmDisassemblerLib/Aarch64Disassembler.c
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
#include <Library/ArmDisassemblerLib.h>

/**
Place a disassembly of of **OpCodePtr into buffer, and update OpCodePtr to
Place a disassembly of **OpCodePtr into buffer, and update OpCodePtr to
point to next instruction.
@param OpCodePtrPtr Pointer to pointer of instruction to disassemble.
Expand Down
4 changes: 2 additions & 2 deletions ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,8 @@ RotateRight (


/**
Place a dissasembly of of **OpCodePtr into buffer, and update OpCodePtr to
point to next instructin.
Place a disassembly of **OpCodePtr into buffer, and update OpCodePtr to
point to next instruction.
We cheat and only decode instructions that access
memory. If the instruction is not found we dump the instruction in hex.
Expand Down
14 changes: 7 additions & 7 deletions ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/** @file
Thumb Dissassembler. Still a work in progress.
Thumb Disassembler. Still a work in progress.
Wrong output is a bug, so please fix it.
Hex output means there is not yet an entry or a decode bug.
Expand Down Expand Up @@ -103,7 +103,7 @@ typedef struct {
} THUMB_INSTRUCTIONS;

THUMB_INSTRUCTIONS gOpThumb[] = {
// Thumb 16-bit instrucitons
// Thumb 16-bit instructions
// Op Mask Format
{ "ADC" , 0x4140, 0xffc0, DATA_FORMAT5 }, // ADC <Rndn>, <Rm>
{ "ADR", 0xa000, 0xf800, ADR_FORMAT }, // ADR <Rd>, <label>
Expand Down Expand Up @@ -447,7 +447,7 @@ SignExtend32 (

//
// Some instructions specify the PC is always considered aligned
// The PC is after the instruction that is excuting. So you pass
// The PC is after the instruction that is executing. So you pass
// in the instruction address and you get back the aligned answer
//
UINT32
Expand All @@ -459,8 +459,8 @@ PCAlign4 (
}

/**
Place a dissasembly of of **OpCodePtr into buffer, and update OpCodePtr to
point to next instructin.
Place a disassembly of **OpCodePtr into buffer, and update OpCodePtr to
point to next instruction.
We cheat and only decode instructions that access
memory. If the instruction is not found we dump the instruction in hex.
Expand Down Expand Up @@ -1023,8 +1023,8 @@ DisassembleArmInstruction (


/**
Place a dissasembly of of **OpCodePtr into buffer, and update OpCodePtr to
point to next instructin.
Place a disassembly of **OpCodePtr into buffer, and update OpCodePtr to
point to next instruction.
We cheat and only decode instructions that access
memory. If the instruction is not found we dump the instruction in hex.
Expand Down
2 changes: 1 addition & 1 deletion ArmPkg/Library/ArmExceptionLib/Arm/ExceptionSupport.S
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ ASM_PFX(AsmCommonExceptionEntry):
ldr R5, [SP, #0x58] @ PC is the LR pushed by srsfd
@ Check to see if we have to adjust for Thumb entry
sub r4, r0, #1 @ if (ExceptionType == 1 || ExceptionType == 2)) {
cmp r4, #1 @ // UND & SVC have differnt LR adjust for Thumb
cmp r4, #1 @ // UND & SVC have different LR adjust for Thumb
bhi NoAdjustNeeded

tst r1, #0x20 @ if ((CPSR & T)) == T) { // Thumb Mode on entry
Expand Down
2 changes: 1 addition & 1 deletion ArmPkg/Library/ArmExceptionLib/Arm/ExceptionSupport.asm
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ AsmCommonExceptionEntry
ldr R5, [SP, #0x58] ; PC is the LR pushed by srsfd
; Check to see if we have to adjust for Thumb entry
sub r4, r0, #1 ; if (ExceptionType == 1 || ExceptionType == 2)) {
cmp r4, #1 ; // UND & SVC have differnt LR adjust for Thumb
cmp r4, #1 ; // UND & SVC have different LR adjust for Thumb
bhi NoAdjustNeeded

tst r1, #0x20 ; if ((CPSR & T)) == T) { // Thumb Mode on entry
Expand Down
4 changes: 2 additions & 2 deletions ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.c
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ InitializeCpuExceptionHandlers(

Status = EFI_SUCCESS;

// if we are requested to copy exceptin handlers to another location
// if we are requested to copy exception handlers to another location
if (gArmRelocateVectorTable) {

VectorBase = PcdGet64(PcdCpuVectorBaseAddress);
Expand Down Expand Up @@ -131,7 +131,7 @@ InitializeCpuExceptionHandlers(
}

/**
Copies exception handlers to the speciifed address.
Copies exception handlers to the specified address.
Caller should try to get an array of interrupt and/or exception vectors that are in use and need to
persist by EFI_VECTOR_HANDOFF_INFO defined in PI 1.3 specification.
Expand Down
6 changes: 3 additions & 3 deletions ArmPkg/Library/ArmLib/AArch64/AArch64Support.S
Original file line number Diff line number Diff line change
Expand Up @@ -430,13 +430,13 @@ ASM_FUNC(ArmReadMpidr)
ret


// Keep old function names for C compatibilty for now. Change later?
// Keep old function names for C compatibility for now. Change later?
ASM_FUNC(ArmReadTpidrurw)
mrs x0, tpidr_el0 // read tpidr_el0 (v7 TPIDRURW) -> (v8 TPIDR_EL0)
ret


// Keep old function names for C compatibilty for now. Change later?
// Keep old function names for C compatibility for now. Change later?
ASM_FUNC(ArmWriteTpidrurw)
msr tpidr_el0, x0 // write tpidr_el0 (v7 TPIDRURW) -> (v8 TPIDR_EL0)
ret
Expand All @@ -453,7 +453,7 @@ ASM_FUNC(ArmReadIdPfr0)
ret


// Q: id_aa64pfr1_el1 not defined yet. What does this funtion want to access?
// Q: id_aa64pfr1_el1 not defined yet. What does this function want to access?
// A: used to setup arch timer. Check if we have security extensions, permissions to set stuff.
// See: ArmPkg/Library/ArmArchTimerLib/AArch64/ArmArchTimerLib.c
// Not defined yet, but stick in here for now, should read all zeros.
Expand Down
2 changes: 1 addition & 1 deletion ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@


ASM_FUNC(ArmIsMpCore)
mrs x0, mpidr_el1 // Read EL1 Mutliprocessor Affinty Reg (MPIDR)
mrs x0, mpidr_el1 // Read EL1 Multiprocessor Affinty Reg (MPIDR)
and x0, x0, #MPIDR_U_MASK // U Bit clear, the processor is part of a multiprocessor system
lsr x0, x0, #MPIDR_U_BIT
eor x0, x0, #1
Expand Down
2 changes: 1 addition & 1 deletion ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ UpdateRegionMapping (

do {
// Get the first Block Entry that matches the Virtual Address and also the information on the Table Descriptor
// such as the the size of the Block Entry and the address of the last BlockEntry of the Table Descriptor
// such as the size of the Block Entry and the address of the last BlockEntry of the Table Descriptor
BlockEntrySize = RegionLength;
BlockEntry = GetBlockEntryListFromAddress (RootTable, RegionStart, &TableLevel, &BlockEntrySize, &LastBlockEntry);
if (BlockEntry == NULL) {
Expand Down
2 changes: 1 addition & 1 deletion ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibCore.c
Original file line number Diff line number Diff line change
Expand Up @@ -691,7 +691,7 @@ UpdateSectionEntries (
for(i=0; i<NumSections; i++) {
CurrentDescriptor = FirstLevelTable[FirstLevelIdx + i];

// has this descriptor already been coverted to pages?
// has this descriptor already been converted to pages?
if (TT_DESCRIPTOR_SECTION_TYPE_IS_PAGE_TABLE(CurrentDescriptor)) {
// forward this 1MB range to page table function instead
Status = UpdatePageEntries (
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#/** @file
# PeCoff extra action libary for DXE phase that run Unix emulator.
# PeCoff extra action library for DXE phase that run Unix emulator.
#
# Lib to provide memory journal status code reporting Routines
# Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.<BR>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ BaseName (
/**
This is the default action to take on an unexpected exception
Since this is exception context don't do anything crazy like try to allcoate memory.
Since this is exception context don't do anything crazy like try to allocate memory.
@param ExceptionType Type of the exception
@param SystemContext Register state at the time of the Exception
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ STATIC CHAR8 *gExceptionTypeString[] = {
/**
This is the default action to take on an unexpected exception
Since this is exception context don't do anything crazy like try to allcoate memory.
Since this is exception context don't do anything crazy like try to allocate memory.
@param ExceptionType Type of the exception
@param SystemContext Register state at the time of the Exception
Expand Down
4 changes: 2 additions & 2 deletions ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
Original file line number Diff line number Diff line change
Expand Up @@ -650,11 +650,11 @@ HandleCapsules (
Do the platform specific action after the console is ready
Possible things that can be done in PlatformBootManagerAfterConsole:
> Console post action:
> Dynamically switch output mode from 100x31 to 80x25 for certain senarino
> Dynamically switch output mode from 100x31 to 80x25 for certain scenario
> Signal console ready platform customized event
> Run diagnostics like memory testing
> Connect certain devices
> Dispatch aditional option roms
> Dispatch additional option roms
> Special boot: e.g.: USB boot, enter UI
**/
VOID
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
/**
Append string to debugger script file, create file if needed.
This library can show up in mulitple places so we need to append the file every time we write to it.
This library can show up in multiple places so we need to append the file every time we write to it.
For example Sec can use this to load the DXE core, and the DXE core would use this to load all the
other modules. So we have two instances of the library in the system.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#/** @file
# PeCoff extra action libary for DXE phase that run Unix emulator.
# PeCoff extra action library for DXE phase that run Unix emulator.
#
# Lib to provide memory journal status code reporting Routines
# Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.<BR>
Expand Down
Loading

0 comments on commit ff5fef1

Please sign in to comment.