Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Dapper free build alternative #254

Merged
merged 8 commits into from
Dec 20, 2023

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Dec 8, 2023

Signed-off-by: Derek Nola [email protected]

Changes

  • Add make no-dapper which uses a regular multistage docker build to match dapper functionality.
  • Consolidate the two validate scripts into one
  • Bump dapper image in CI
  • Nit: Spelling mistakes fixed

Performance

Kine already builds quickly, so the goal was to match performance.

Change dapper no-dapper
Run 1 Clean build (clean docker image/cache) 1m28s 1m33s
Run 2 Tagged build 18.7s 8.5s
Run 3 skip validate, code change my.sql:119 9.7s 8.4s
Run 4 no change (test caching efficiency) 10.3s 5.3s

@dereknola dereknola force-pushed the even_less_dapper branch 2 times, most recently from 4d53914 to d7c87b7 Compare December 8, 2023 18:53
@dereknola dereknola force-pushed the even_less_dapper branch 4 times, most recently from 8ca4056 to 00574bf Compare December 8, 2023 19:49
@dereknola dereknola marked this pull request as ready for review December 8, 2023 19:52
@dereknola dereknola requested a review from a team as a code owner December 8, 2023 19:52
.drone.yml Outdated Show resolved Hide resolved
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
@brandond
Copy link
Member

merge when ready!

@dereknola dereknola merged commit f7ae7ce into k3s-io:master Dec 20, 2023
2 checks passed
@dereknola dereknola deleted the even_less_dapper branch May 29, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants