Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update membership template #49

Closed
wants to merge 14 commits into from
Closed

Conversation

jenshu
Copy link
Contributor

@jenshu jenshu commented Jan 10, 2025

No description provided.

@jenshu jenshu requested review from a team, ilevine, ilrudie, linsun and yuval-k as code owners January 10, 2025 05:03
Copy link
Contributor

@ilrudie ilrudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on sorting this out. Couple questions

.github/PULL_REQUEST_TEMPLATE/apply_to_be_a_member.md Outdated Show resolved Hide resolved
CONTRIBUTOR_LADDER.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
CONTRIBUTOR_LADDER.md Outdated Show resolved Hide resolved
CONTRIBUTOR_LADDER.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ilrudie ilrudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple quick wording fixes. I say we tackle those and then merge. TY

ilrudie and others added 13 commits January 10, 2025 10:24
* notes on commit signing

Signed-off-by: Ian Rudie <[email protected]>

* add commit signing to task list

Signed-off-by: Ian Rudie <[email protected]>

* big rewrite

Signed-off-by: Ian Rudie <[email protected]>

* remove commit signing from template, it's in contrib guide already and we ask that they attest they are familiar with that document already

Signed-off-by: Ian Rudie <[email protected]>

* fix bad md comment syntax

Signed-off-by: Ian Rudie <[email protected]>

* small callout about reporting security issues

Signed-off-by: Ian Rudie <[email protected]>

* add a TODO wrt the unstable state of our changelog processes

Signed-off-by: Ian Rudie <[email protected]>

---------

Signed-off-by: Ian Rudie <[email protected]>
Signed-off-by: Jenny Shu <[email protected]>
Signed-off-by: Jenny Shu <[email protected]>
Signed-off-by: Jenny Shu <[email protected]>
Signed-off-by: Ian Rudie <[email protected]>
Signed-off-by: Jenny Shu <[email protected]>
Signed-off-by: Jenny Shu <[email protected]>
Signed-off-by: Jenny Shu <[email protected]>
Signed-off-by: Jenny Shu <[email protected]>
Signed-off-by: Jenny Shu <[email protected]>
Co-authored-by: Ian Rudie <[email protected]>
Signed-off-by: Jenny Shu <[email protected]>
Co-authored-by: Ian Rudie <[email protected]>
Signed-off-by: Jenny Shu <[email protected]>
@jenshu
Copy link
Contributor Author

jenshu commented Jan 10, 2025

the rebase messed up the commits, going to close in favor of #50

@jenshu jenshu closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants