Verify PVCs are not used by any Pods before deleting them #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmanm
changed the title
rzvoncek
approved these changes
Jan 24, 2025
| logger.Error(err, "Failed to check if PVC is being used") | ||
| return err | ||
| } else if isBeingUsed { | ||
| return fmt.Errorf("PersistentVolumeClaim %s is still being used by a pod", pvc.Name) |
There was a problem hiding this comment.
Question: Upon ordinarily deleting a k8ssandra cluster, I've seen a bunch of ERROR lines caused by this in the operator logs. I understand it's a normal pattern to error out until a condition (in this case pod existence) changes. But the "ERROR Reconciler error" seems a bit harsh. Perhaps we can do something to soften this?
There was a problem hiding this comment.
That logging comes from the controller-runtime, so there's not much we can do about it. A warn in the case of reconciler error which retry might fix makes sense, but I'm not aware of having that ability.
In the end, it's still an error. It's not like we would log this at "FATAL".
…a PVC, verify that no Pods match this index search
…d only then delete the CassandraDatacenter
burmanm
force-pushed
the
prevent_pvc_deletion-mc-1398
branch
from
7983384 to
1082eee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…a PVC, verify that no Pods match this index search
What this PR does:
Verify that PersistentVolumeClaim is not used by any Pod before deleting it, in case there were some ghost pods still existing with the PVC mounted.
Which issue(s) this PR fixes:
Fixes #737
Checklist