refactor(http-client): Decouple components of Http clients

- Extract ApiServerClientFactory from ApiSeverClient
- Create CoroutinePool for coroutine scheduling and error handling
- Improve coroutines handling and testing

src/Bridge/Symfony/Bundle/Command/ServerStatusCommand.php

@@ -5,7 +5,9 @@
 namespace K911\Swoole\Bridge\Symfony\Bundle\Command;
 
 use Assert\Assertion;
-use K911\Swoole\Server\Api\ApiServerInterface;
+use K911\Swoole\Client\Exception\ClientConnectionErrorException;
+use K911\Swoole\Coroutine\CoroutinePool;
+use K911\Swoole\Server\Api\ApiServerClientFactory;
 use K911\Swoole\Server\Config\Socket;
 use K911\Swoole\Server\Config\Sockets;
 use Symfony\Component\Console\Command\Command;
@@ -17,18 +19,17 @@
 
 final class ServerStatusCommand extends Command
 {
-    private $apiServer;
+    private $apiServerClientFactory;
     private $sockets;
     private $parameterBag;
-    private $testing = false;
 
     public function __construct(
         Sockets $sockets,
-        ApiServerInterface $apiServer,
+        ApiServerClientFactory $apiServerClientFactory,
         ParameterBagInterface $parameterBag
     ) {
-        $this->apiServer = $apiServer;
         $this->sockets = $sockets;
+        $this->apiServerClientFactory = $apiServerClientFactory;
         $this->parameterBag = $parameterBag;
 
         parent::__construct();
@@ -48,40 +49,35 @@ protected function configure(): void
      * {@inheritdoc}
      *
      * @throws \Assert\AssertionFailedException
+     * @throws \Throwable
      */
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
+        $exitCode = 0;
         $io = new SymfonyStyle($input, $output);
 
         $this->prepareClientConfiguration($input);
 
-        $this->goAndWait(function () use ($io): void {
-            try {
-                $status = $this->apiServer->status();
-                $metrics = $this->apiServer->metrics();
-            } catch (\RuntimeException $runtimeException) {
-                $io->error('Could not connect to Swoole API Server');
-
-                return;
-            }
-            $io->success('Fetched status and metrics');
+        $coroutinePool = CoroutinePool::fromCoroutines(function () use ($io): void {
+            $status = $this->apiServerClientFactory->newClient()
+                ->status();
+            $io->success('Fetched status');
             $this->showStatus($io, $status);
+        }, function () use ($io): void {
+            $metrics = $this->apiServerClientFactory->newClient()
+                ->metrics();
+            $io->success('Fetched metrics');
             $this->showMetrics($io, $metrics);
         });
 
-        return 0;
-    }
-
-    public function goAndWait(callable $callback): void
-    {
-        if ($this->testing) {
-            $callback();
-
-            return;
+        try {
+            $coroutinePool->run();
+        } catch (ClientConnectionErrorException $errorException) {
+            $io->error('An error occurred while connecting to the API Server. Please verify configuration.');
+            $exitCode = 1;
         }
 
-        \go($callback);
-        \swoole_event_wait();
+        return $exitCode;
     }
 
     private function showStatus(SymfonyStyle $io, array $status): void
@@ -147,9 +143,4 @@ protected function prepareClientConfiguration(InputInterface $input): void
 
         $this->sockets->changeApiSocket(new Socket($host, (int) $port));
     }
-
-    public function enableTestMode(): void
-    {
-        $this->testing = true;
-    }
 }

src/Bridge/Symfony/Bundle/Resources/config/commands.yaml

@@ -6,8 +6,6 @@ services:
 
     'K911\Swoole\Bridge\Symfony\Bundle\Command\ServerStatusCommand':
         tags: [ { name: console.command, command: 'swoole:server:status' } ]
-        arguments:
-            $apiServer: '@K911\Swoole\Server\Api\ApiServerClient'
 
     'K911\Swoole\Bridge\Symfony\Bundle\Command\ServerStopCommand':
         tags: [ { name: console.command, command: 'swoole:server:stop' } ]

src/Bridge/Symfony/Bundle/Resources/config/services.yaml

@@ -49,7 +49,10 @@ services:
     'K911\Swoole\Server\LifecycleHandler\ServerManagerStopHandlerInterface':
         class: K911\Swoole\Server\LifecycleHandler\NoOpServerManagerStopHandler
 
+    'K911\Swoole\Server\Api\ApiServerClientFactory':
+
     'K911\Swoole\Server\Api\ApiServerClient':
+        factory: 'K911\Swoole\Server\Api\ApiServerClientFactory:newClient'
 
     'K911\Swoole\Server\Api\ApiServerInterface':
         class: K911\Swoole\Server\Api\ApiServer

src/Client/Exception/ClientConnectionErrorException.php

@@ -26,6 +26,6 @@ public static function serverReset(int $errorCode): self
 
     public static function unknown(int $errorCode): self
     {
-        return new self('Unknown', $errorCode);
+        return new self(\sprintf('Unknown [%d]', $errorCode), $errorCode);
     }
 }

src/Client/Exception/MissingContentTypeException.php

@@ -9,8 +9,8 @@
  */
 final class MissingContentTypeException extends \InvalidArgumentException
 {
-    public static function create(): self
+    public static function make(): self
     {
-        return new self(\sprintf('Server response did not contain Content-Type.'));
+        return new self(\sprintf('Server response did not contain mandatory header "Content-Type".'));
     }
 }

src/Client/Exception/UnsupportedContentTypeException.php

@@ -0,0 +1,22 @@
+<?php
+
+declare(strict_types=1);
+
+namespace K911\Swoole\Client\Exception;
+
+/**
+ * @internal
+ */
+final class UnsupportedContentTypeException extends \InvalidArgumentException
+{
+    /**
+     * @param string   $contentType
+     * @param string[] $allowed
+     *
+     * @return UnsupportedContentTypeException
+     */
+    public static function forContentType(string $contentType, array $allowed): self
+    {
+        return new self(\sprintf('Content-Type "%s" is not supported. Only "%s" are supported.', $contentType, \implode(', ', $allowed)));
+    }
+}

src/Client/Exception/UnsupportedHttpMethodException.php

@@ -0,0 +1,22 @@
+<?php
+
+declare(strict_types=1);
+
+namespace K911\Swoole\Client\Exception;
+
+/**
+ * @internal
+ */
+final class UnsupportedHttpMethodException extends \InvalidArgumentException
+{
+    /**
+     * @param string   $method
+     * @param string[] $allowed
+     *
+     * @return UnsupportedHttpMethodException
+     */
+    public static function forMethod(string $method, array $allowed): self
+    {
+        return new self(\sprintf('Http method "%s" is not supported. Only "%s" are supported.', $method, \implode(', ', $allowed)));
+    }
+}