This repository has been archived by the owner on Jan 17, 2022. It is now read-only.
feat(server): handle signals to enable graceful termination #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k911
added
kind/feature
k911
force-pushed
the
feat/signal-handling
branch
8 times, most recently
from
4cc5995 to
08ea403
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## develop #459 +/- ##
=============================================
- Coverage 86.03% 83.20% -2.84%
- Complexity 654 723 +69
=============================================
Files 96 109 +13
Lines 2070 2257 +187
=============================================
+ Hits 1781 1878 +97
- Misses 289 379 +90
|
k911
force-pushed
the
feat/signal-handling
branch
6 times, most recently
from
d09b4a8 to
e738805
Compare
|
|
||
| final class SwooleErrorOnConsoleTerminateEvent | ||
| { | ||
| public function onConsoleTerminate(ConsoleTerminateEvent $event): void |
There was a problem hiding this comment.
Remove the unused function parameter "$event".
|
|
||
| final class SwooleErrorOnConsoleTerminateEvent | ||
| { | ||
| public function onConsoleTerminate(ConsoleTerminateEvent $event): void |
There was a problem hiding this comment.
Avoid unused parameters such as '$event'.
k911
force-pushed
the
feat/signal-handling
branch
from
b3d4eef to
b3a7bd4
Compare
k911
force-pushed
the
feat/signal-handling
branch
from
b3a7bd4 to
d7e84ed
Compare
k911
force-pushed
the
feat/signal-handling
branch
from
d7e84ed to
3b91333
Compare
k911
force-pushed
the
feat/signal-handling
branch
4 times, most recently
from
483be61 to
f26faa6
Compare
k911
force-pushed
the
feat/signal-handling
branch
from
f26faa6 to
26e0c21
Compare
|
Code Climate has analyzed commit 26e0c21 and detected 5 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 56.6% (50% is the threshold). This pull request will bring the total coverage in the repository to 81.3% (-4.7% change). View more on Code Climate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.