Skip to content
This repository has been archived by the owner on Jan 17, 2022. It is now read-only.

Fix ApiServerClient factory #565

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

dotdevio
Copy link

@dotdevio dotdevio commented Dec 2, 2021

In Symfony 5.4 factory format is wrong. Should be "::" not ":"

    K911\Swoole\Server\Api\ApiServerClient:
        factory: K911\Swoole\Server\Api\ApiServerClientFactory:newClient
    K911\Swoole\Server\Api\ApiServerClient:
        factory: K911\Swoole\Server\Api\ApiServerClientFactory::newClient

@dotdevio dotdevio requested a review from k911 as a code owner December 2, 2021 02:44
@k911
Copy link
Owner

k911 commented Dec 12, 2021

Hi @dotdevq, just wanted to inform you that your commit message currently fails validation. Please see contributing guide

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants