-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stable test output in logs #272
Conversation
c543958
to
04b5b6a
Compare
I love the idea, but I would suggest a slightly different implementation. Rather than copy-pasting long formula type ResultMap = Map[LanguageCompilerStatic, String] And it's actually exactly how all test functions are defined: def full(src: String, srcType: DataType, expType: DataType, expOut: ResultMap)
def full(src: String, tp: TypeProvider, expType: DataType, expOut: ResultMap)
def everybody(src: String, expOut: String, expType: DataType = CalcIntType)
def everybodyExcept(src: String, commonExpOut: String, rm: ResultMap, expType: DataType = CalcIntType) Shall we just swap that to use ListMap + then swap all the test invocations to use ResultMap instead of lengthy |
04b5b6a
to
9f323ed
Compare
jvm/src/test/scala/io/kaitai/struct/translators/TranslatorSpec.scala
Outdated
Show resolved
Hide resolved
adb303b
to
4a15dc3
Compare
… the same order This will result the same order of failed tests in the logs which makes it much more easy to compare Co-authored-by: Petr Pučil <[email protected]>
4a15dc3
to
1bf9af9
Compare
jvm/src/test/scala/io/kaitai/struct/translators/TranslatorSpec.scala
Outdated
Show resolved
Hide resolved
6021511
to
49e82a4
Compare
@Mingun Any objections to merge it this way, or we're good to go? |
I have no objections, please merge. |
Use
ListMap
to represent expected test results so tests always run in the same order.This will result the same order of failed tests in the logs which makes it much more easy to compare.