Code

Fix enum and type resolution#309

Code

Open

Mingun wants to merge 12 commits intokaitai-io:masterkaitai-io/kaitai_struct_compiler:masterfrom Mingun:fix-type-resolutionMingun/kaitai_struct_compiler:fix-type-resolutionCopy head branch name to clipboard

+986-169

Commits

Commits on Oct 4, 2024

• Rename auxiliary functions that implements resolving type and enum names

  Show description for 6ce37a4
  Mingun

  committed
  6ce37a4

  Copy full SHA for 6ce37a4

• Wrap type name in '' because it is not always clear that part of a message is a type name

  Show description for 9cc21cf
  Mingun

  committed
  9cc21cf

  Copy full SHA for 9cc21cf

• Add tests for type name resolution

  Show description for 04ba421
  Mingun

  committed
  04ba421

  Copy full SHA for 04ba421

• Fix type resolution in expressions

  Show description for 4ec107f
  Mingun

  committed
  4ec107f

  Copy full SHA for 4ec107f

• Add tests for enum resolution in expressions

  Show description for ce3875e
  Mingun

  committed
  ce3875e

  Copy full SHA for ce3875e

• Fix enum resolution in expressions

  Show description for 8033407
  Mingun

  committed
  8033407

  Copy full SHA for 8033407

• Remove now used only in one place ClassTypeProvider.resolveClassSpec

  Mingun

  committed
  374dc8b

  Copy full SHA for 374dc8b

• Make all internal methods of ResolveTypes pass private

  Mingun

  committed
  64d770b

  Copy full SHA for 64d770b

• Fix enum resolution in enum keys

  Show description for 9cac8d2
  Mingun

  committed
  9cac8d2

  Copy full SHA for 9cac8d2

• Fix type resolution in type keys

  Show description for 7697cac
  Mingun

  committed
  7697cac

  Copy full SHA for 7697cac

• Remove unnecessary variable and matching

  Mingun

  committed
  a4706e7

  Copy full SHA for a4706e7

• Inline real type resolution method

  Show description for 3e68dcc
  Mingun

  committed
  3e68dcc

  Copy full SHA for 3e68dcc