Normalize node paths in errors (for compiler#229) #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mingun
force-pushed
the
normalize-error-paths
branch
from
e61596e to
f162c10
Compare
Mingun
force-pushed
the
normalize-error-paths
branch
from
f162c10 to
1191594
Compare
Mingun
force-pushed
the
normalize-error-paths
branch
from
1191594 to
1a8ba6c
Compare
Mingun
force-pushed
the
normalize-error-paths
branch
from
1a8ba6c to
c6ec3b1
Compare
Mingun
changed the title
This change requires corresponding change in kaitai_struct_compiler repository
This change requires corresponding change in kaitai_struct_compiler repository
TypeValidator.validateSwitchType uses path with "type" therefore this is just behavior unification This change requires corresponding change in kaitai_struct_compiler repository
… type/enum" errors This change requires corresponding change in kaitai_struct_compiler repository
Mingun
force-pushed
the
normalize-error-paths
branch
from
c6ec3b1 to
9c24d1c
Compare
|
Looks good to me, I think this gets us into much better territory in terms of error reporting. |
Mingun
added a commit
to Mingun/kaitai_struct_tests
that referenced
this pull request
Mar 22, 2024
…tai-io#92 Fixes the test ``` [info] - type_unknown_many *** FAILED *** [info] type_unknown_many.ksy: /seq/0/type: [info] error: unable to find type 'some_unknown_name', searching from type_unknown_many [info] [info] type_unknown_many.ksy: /seq/1/type: [info] error: unable to find type 'also_unknown_name', searching from type_unknown_many [info] [info] type_unknown_many.ksy: /seq/2/enum: [info] error: unable to find enum 'unknown_enum', searching from type_unknown_many [info] did not equal type_unknown_many.ksy: /seq/0: [info] error: unable to find type 'some_unknown_name', searching from type_unknown_many [info] [info] type_unknown_many.ksy: /seq/1: [info] error: unable to find type 'also_unknown_name', searching from type_unknown_many [info] [info] type_unknown_many.ksy: /seq/2: [info] error: unable to find enum 'unknown_enum', searching from type_unknown_many (SimpleMatchers.scala:34) ```
GreyCat
pushed a commit
that referenced
this pull request
Mar 22, 2024
Fixes the test ``` [info] - type_unknown_many *** FAILED *** [info] type_unknown_many.ksy: /seq/0/type: [info] error: unable to find type 'some_unknown_name', searching from type_unknown_many [info] [info] type_unknown_many.ksy: /seq/1/type: [info] error: unable to find type 'also_unknown_name', searching from type_unknown_many [info] [info] type_unknown_many.ksy: /seq/2/enum: [info] error: unable to find enum 'unknown_enum', searching from type_unknown_many [info] did not equal type_unknown_many.ksy: /seq/0: [info] error: unable to find type 'some_unknown_name', searching from type_unknown_many [info] [info] type_unknown_many.ksy: /seq/1: [info] error: unable to find type 'also_unknown_name', searching from type_unknown_many [info] [info] type_unknown_many.ksy: /seq/2: [info] error: unable to find enum 'unknown_enum', searching from type_unknown_many (SimpleMatchers.scala:34) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change all paths in errors will point to existing nodes in KSY file and node, where error is originated
This PR should be merged together with kaitai-io/kaitai_struct_compiler#229 where actual fix done