Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fine tune (Part 9) - Handling image data destination #367

Merged
merged 19 commits into from
May 3, 2024

Conversation

ishaansehgal99
Copy link
Collaborator

@ishaansehgal99 ishaansehgal99 commented Apr 30, 2024

Reason for Change:
Sets up the data destination outline. This PR introduces image as first data destination. It includes sidecar container script for detecting finished fine tuning results and uploading results to image data destination

PR also fixes a flaky test - caused by environment variables getting carried over between tests.

@ishaansehgal99 ishaansehgal99 changed the title feat: handling image data destination feat: Handling image data destination Apr 30, 2024
@ishaansehgal99 ishaansehgal99 marked this pull request as draft April 30, 2024 21:00
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 14.37500% with 137 lines in your changes are missing coverage. Please review.

Project coverage is 61.74%. Comparing base (fde6369) to head (52c5a76).
Report is 21 commits behind head on main.

❗ Current head 52c5a76 differs from pull request most recent head d3e118f. Consider uploading reports for the commit d3e118f to get more accurate results

Files Patch % Lines
pkg/tuning/preset-tuning.go 15.74% 90 Missing and 1 partial ⚠️
pkg/utils/common-preset.go 16.66% 29 Missing and 1 partial ⚠️
pkg/resources/manifests.go 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
- Coverage   62.89%   61.74%   -1.15%     
==========================================
  Files          14       29      +15     
  Lines        1307     2227     +920     
==========================================
+ Hits          822     1375     +553     
- Misses        447      785     +338     
- Partials       38       67      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishaansehgal99 ishaansehgal99 marked this pull request as ready for review May 1, 2024 23:19
pkg/tuning/preset-tuning.go Outdated Show resolved Hide resolved
@ishaansehgal99 ishaansehgal99 merged commit 52f5d3b into main May 3, 2024
5 of 7 checks passed
@ishaansehgal99 ishaansehgal99 deleted the Ishaan/push-method branch May 3, 2024 04:56
smritidahal653 pushed a commit to smritidahal653/kaito that referenced this pull request Jun 7, 2024
…ject#367)

**Reason for Change**:
Sets up the data destination outline. This PR introduces image as first
data destination. It includes sidecar container script for detecting
finished fine tuning results and uploading results to image data
destination

PR also fixes a flaky test - caused by environment variables getting
carried over between tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants