fix: chart tpl when rendering feature gate flag #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jerryzhuang <[email protected]>
zhuangqh
requested review from
Fei-Guo,
helayoty and
ishaansehgal99
as code owners
Signed-off-by: jerryzhuang <[email protected]>
zhuangqh
force-pushed
the
fix-chart-tpl
branch
from
e573815 to
974c1c6
Compare
Signed-off-by: jerryzhuang <[email protected]>
Signed-off-by: jerryzhuang <[email protected]>
zhuangqh
commented
Dec 6, 2024
| @@ -7,7 +7,7 @@ export REGISTRY=mcr.microsoft.com/aks/kaito | |||
| export IMG_NAME=workspace | |||
| export IMG_TAG=0.4.0 | |||
| helm install workspace ./charts/kaito/workspace \ | |||
| --set image.repository=${REGISTRY}/$(IMG_NAME) --set image.tag=$(IMG_TAG) \ | |||
| --set image.repository=${REGISTRY}/${IMG_NAME} --set image.tag=${IMG_TAG} \ | |||
There was a problem hiding this comment.
invalid gammer in shell
Fei-Guo
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k=v pair should be joint by comma.