First Draft #2
Open
First Draft #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example karaoke
|
New and updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
peeke
suggested changes
Sep 4, 2023
readme.md
Outdated
| | Key | Initial values | Description | | ||
| |-----------------| --- |---------------------------------------------------------------------------------------------------------------| | ||
| | `subtitles` | `[]` | An array of all subtitles available for the specified language. | | ||
| | `current` | See below. | An object representing the currently active subtitle and metadata, with metadata containing the properties `startTime`, `endTime`, and `text`, and subtitle also containing `voice`[^1]. | |
There was a problem hiding this comment.
Ik zou hier een andere naam aan geven, zodat je meteen snapt wat erin zit. Nu doet current me teveel denken aan een ref, waardoor ik het idee heb dat er iets sketchies gebeurt (wat niet zo is). Wellicht active of activeSubtitle
There was a problem hiding this comment.
Had ik ook, ik zou gaan voor activeSubtitle
| @@ -0,0 +1,23 @@ | |||
| /** @param {{ text: string }} _*/ | |||
| export function getVoiceFromCue({ text }) { | |||
Co-authored-by: Peeke <[email protected]>
Co-authored-by: Peeke <[email protected]>
Co-authored-by: Peeke <[email protected]>
EECOLOR
requested changes
Sep 6, 2023
|
|
||
| | Key | Initial values | Description | | ||
| |-----------------| --- |---------------------------------------------------------------------------------------------------------------| | ||
| | `subtitles` | `[]` | An array of all subtitles available for the specified language. | |
There was a problem hiding this comment.
Deze zag ik volgens mij niet in de voorbeelden in de readme terug komen
There was a problem hiding this comment.
Het is ook nog onduidelijk wat de structuur is van subtitles, Ik zou gokken dat het dit is:
subtitles: Array<Subtitle>
activeSubtitle: Subtitle
ref: React.RefEn dan kun je Subtitle beschrijven.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
metadatacan be JSON, as per WebVTT specvoiceis parsed from cues, as per WebVTT spec