extract() <=> data buffer is owning #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschimek
changed the title
niklas-uhl
approved these changes
Jan 8, 2024
include/kamping/result.hpp
Outdated
| /// @brief Helper for implementing the extract_* functions in \ref MPIResult. Is \c true if the passed buffer type owns | ||
| /// its underlying storage and is an output buffer. | ||
| template <typename Buffer> | ||
| inline constexpr bool is_extractable = Buffer::is_owning& Buffer::is_out_buffer; |
There was a problem hiding this comment.
Suggested change
| inline constexpr bool is_extractable = Buffer::is_owning& Buffer::is_out_buffer; | |
| inline constexpr bool is_extractable = Buffer::is_owning && Buffer::is_out_buffer; |
There was a problem hiding this comment.
Why is this located in this header? I think this should be part of DataBuffer.
Nevermind, it makes sense with the specialization for ResultCategoryNotUsed. Still, I think we should have Buffer::is_extractable.
There was a problem hiding this comment.
Should this be in the internal namespace?
niklas-uhl
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataBuffer::extract() is now available if only if DataBuffer::is_owning, i.e. the data buffer owns its underlying storage.
The distinction between in/out buffers is now made in the result object and is (somewhat) decoupled from the existence of the extract() member function.
First step for enabling structured-binding ready result objects.