Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set logger error #1099

Closed
wants to merge 6 commits into from
Closed

Set logger error #1099

wants to merge 6 commits into from

Conversation

dav9
Copy link

@dav9 dav9 commented Dec 3, 2023

Fixes kapitan compile shows output from like:

creating ...
copying ... -> ...

It comes from: https://github.com/pypa/distutils/blob/main/distutils/file_util.py#L135

Proposed Changes

  • setup all loggers on error
  • keep kapitan and reclass on info as output such as Rendered inventory and Compiled target are emitted through it.
  • kapitan inventory and compile has a paramter --logging-config that allows a yaml file.

Docs and Tests

  • [] Tests added
  • Updated documentation

@dav9 dav9 force-pushed the set_logger_error branch from cbdc2b6 to 8181e59 Compare December 7, 2023 15:49
@dav9 dav9 mentioned this pull request Dec 8, 2023
Open
@ademariag ademariag requested a review from ramaro December 18, 2023 10:36
@github-actions github-actions bot added the Stale label Feb 17, 2024
@github-actions github-actions bot removed the Stale label May 10, 2024
@github-actions github-actions bot added the Stale label Jul 9, 2024
@ademariag
Copy link
Contributor

we removed distutils so no longer relevant. But thank you and sorry it took so long to review

@ademariag ademariag closed this Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramaro ramaro Awaiting requested review from ramaro

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dav9 @ademariag