Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Makes parent configurable #562

Merged
merged 3 commits into from
Dec 17, 2024
Merged

feat: Makes parent configurable #562

merged 3 commits into from
Dec 17, 2024

Conversation

mflerackers
Copy link
Member

No description provided.

@mflerackers mflerackers self-assigned this Dec 15, 2024
@mflerackers mflerackers requested a review from lajbel December 15, 2024 09:40
@mflerackers mflerackers added the enhancement New feature or request label Dec 15, 2024
Copy link

pkg-pr-new bot commented Dec 15, 2024

Open in Stackblitz

npm i https://pkg.pr.new/kaplayjs/kaplay@562

commit: 519bc20

@dragoncoder047
Copy link
Contributor

Are keepFlags exported on kaplay context?

@mflerackers
Copy link
Member Author

mflerackers commented Dec 15, 2024 via email

@dragoncoder047
Copy link
Contributor

If anything, this one should be, because it's not immediately clear what { keep: 7 } means. 7 is just a magic number until you look at the keep flags enum. It would be more obvious if you could do { keep: KeepFlags.ALL }

@lajbel lajbel merged commit 784115a into master Dec 17, 2024
3 checks passed
dragoncoder047 added a commit to dragoncoder047/kaplay that referenced this pull request Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants