chore: Isolate global constants to module. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
( Also add .replit to gitignore so push can be made without gross clutter )
Pull latest changes
|
.gitignore is conflicting. removing .replit will fix it as .replit and replit.nix is now in gitignore. the test failing seems to be my fault, will be fixed. |
lajbel
approved these changes
May 22, 2024
| root.appendChild(canvas); | ||
| return canvas; | ||
| })(); | ||
| const canvas = gopt.canvas ?? root.appendChild(document.createElement("canvas")) |
There was a problem hiding this comment.
Not related to PR, I'll let it go this time
There was a problem hiding this comment.
Yeah, that's fine, commited it and am not sure how to separate to different PR after.
|
just updated tests. should fix the issue after pull |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.