Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump upgrade helm chart index to v1.12.0 #5918

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

chaosi-zju
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Bump upgrade helm chart index to v1.12.0

Which issue(s) this PR fixes:

Fixes

Does this PR introduce a user-facing change?:

upgrade helm chart index to v1.12.0.

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 9, 2024
@karmada-bot karmada-bot requested review from pidb and Poor12 December 9, 2024 04:16
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 9, 2024
@chaosi-zju
Copy link
Member Author

manual generated by script in #5911

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.93%. Comparing base (8f506d4) to head (2e36b85).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5918      +/-   ##
==========================================
- Coverage   47.95%   47.93%   -0.03%     
==========================================
  Files         663      663              
  Lines       54761    54769       +8     
==========================================
- Hits        26261    26253       -8     
- Misses      26794    26809      +15     
- Partials     1706     1707       +1     
Flag Coverage Δ
unittests 47.93% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @a7i
Can you help take a look and approval?

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2024
@a7i
Copy link
Contributor

a7i commented Dec 9, 2024

🏆
/lgtm

@chaosi-zju
Copy link
Member Author

/cc @RainbowMango can this PR move forward?

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
on behalf of chart owners :)

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2024
@karmada-bot karmada-bot merged commit a6df137 into karmada-io:master Dec 11, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants