Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flake test of KarmadactlTopPod #5933

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

zhzhuang-zju
Copy link
Contributor

What type of PR is this?
/kind flake
/kind failing-test

What this PR does / why we need it:
The e2e test Karmadactl top testing Karmadactl top pod which does not exist [It] Karmadactl top pod which does not exist has been intermittently failing.
See, https://github.com/karmada-io/karmada/actions/runs/12197101877/job/34026335469?pr=5772#step:6:1770

the e2e fails because the member cluster's server is not available at this time.

error: cluster(member1): the server is currently unable to handle the request (get pods.metrics.k8s.io pod-z682t)

We are unable to determine why the metrics-server in member1 cannot handle requests due to the absence of logs from the member cluster and uncertainty regarding whether this is a transient service outage. However, we can enhance the end-to-end (e2e) stability by implementing retry logic.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE.

@karmada-bot karmada-bot added kind/flake Categorizes issue or PR as related to a flaky test. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Dec 10, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 10, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.08%. Comparing base (ff7dc4a) to head (35c4adf).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5933      +/-   ##
==========================================
- Coverage   48.10%   48.08%   -0.03%     
==========================================
  Files         663      663              
  Lines       54769    54769              
==========================================
- Hits        26347    26336      -11     
- Misses      26713    26721       +8     
- Partials     1709     1712       +3     
Flag Coverage Δ
unittests 48.08% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
@karmada-bot karmada-bot merged commit 8457cd2 into karmada-io:master Dec 10, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants