Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce apply clientset for CRD in work group #6002

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Monokaix
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
SSA (Server Side Apply) is a good design to avoid update resource conflict and k8s also has supported Apply client to support that, we can introduce these features to avoid update resource conflict, please see https://kubernetes.io/docs/reference/using-api/server-side-apply/, https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/2155-clientgo-apply, kubernetes/kubernetes#99214 for more detail.
And also karmada has used many retry update mechanism, eg:

if err = retry.RetryOnConflict(retry.DefaultRetry, func() error {

this is not a good habit and will cause performance issue too, SSA can help a lot.
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
This pr just introduced CRDs in work group, because the pr #5937 need that and we can add more CRD support in the future, we can add them as needed.
Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 31, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rainbowmango for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 31, 2024
@Monokaix Monokaix changed the title Apply Introduce apply clientset for CRD in work group Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants