Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update community meeting time #6033

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

gabrielsrs
Copy link

@gabrielsrs gabrielsrs commented Jan 9, 2025

What type of PR is this?

/kind documentation

What this PR does / why we need it:

  • Update the meeting(English) time, referred to in this conversation

Which issue(s) this PR fixes:
Part of #6030

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Jan 9, 2025
@karmada-bot
Copy link
Collaborator

Welcome @gabrielsrs! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 9, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.37%. Comparing base (be674c7) to head (8f53065).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6033      +/-   ##
==========================================
- Coverage   48.37%   48.37%   -0.01%     
==========================================
  Files         665      666       +1     
  Lines       54831    54831              
==========================================
- Hits        26524    26522       -2     
- Misses      26590    26591       +1     
- Partials     1717     1718       +1     
Flag Coverage Δ
unittests 48.37% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Thanks @gabrielsrs for doing this.
I left some comments. Please have a look.

After you fix the comment, please

  1. squash your commits as per https://karmada.io/docs/next/contributor/github-workflow/#squash-commits
  2. sign your commit as per https://github.com/karmada-io/karmada/pull/6033/checks?check_run_id=35402074697

README.md Outdated
@@ -202,7 +202,7 @@ Key:

Regular Community Meeting:
* Tuesday at 14:30 UTC+8 (Chinese)(biweekly). [Convert to your timezone](https://www.thetimezoneconverter.com/?t=14%3A30&tz=GMT%2B8&).
* Tuesday at 08:00 Pacific Time (English)(biweekly). [Convert to your timezone](https://www.thetimezoneconverter.com/?t=8:00&tz=PT%20%28Pacific%20Time%29).
* Tuesday at 08:00 Pacific Time (English)(biweekly). [Convert to your timezone](https://dateful.com/time-zone-converter?t=07:00&tz=PT%20%28Pacific%20Time%29).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Tuesday at 08:00 Pacific Time (English)(biweekly) --> "Tuesday at 15:00 UTC+0 (English)(biweekly)"
  2. This link seems more clear: https://dateful.com/convert/coordinated-universal-time-utc?t=15
  3. Please help update the Chinese meeting timezone link to https://dateful.com/convert/utc8?t=1430

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh ok, I'm making these changes and I'll let you know when I finish.

@karmada-bot karmada-bot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Jan 10, 2025
Signed-off-by: Gabriel Reis <[email protected]>
@karmada-bot karmada-bot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Jan 10, 2025
@gabrielsrs
Copy link
Author

@RainbowMango I made the corrections and sign the commits, see if was this. tks for the attention...

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!
Thank you!
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@karmada-bot karmada-bot merged commit 8313813 into karmada-io:master Jan 10, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants