-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update community meeting time #6033
Conversation
Welcome @gabrielsrs! It looks like this is your first PR to karmada-io/karmada 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6033 +/- ##
==========================================
- Coverage 48.37% 48.37% -0.01%
==========================================
Files 665 666 +1
Lines 54831 54831
==========================================
- Hits 26524 26522 -2
- Misses 26590 26591 +1
- Partials 1717 1718 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Thanks @gabrielsrs for doing this.
I left some comments. Please have a look.
After you fix the comment, please
- squash your commits as per https://karmada.io/docs/next/contributor/github-workflow/#squash-commits
- sign your commit as per https://github.com/karmada-io/karmada/pull/6033/checks?check_run_id=35402074697
README.md
Outdated
@@ -202,7 +202,7 @@ Key: | |||
|
|||
Regular Community Meeting: | |||
* Tuesday at 14:30 UTC+8 (Chinese)(biweekly). [Convert to your timezone](https://www.thetimezoneconverter.com/?t=14%3A30&tz=GMT%2B8&). | |||
* Tuesday at 08:00 Pacific Time (English)(biweekly). [Convert to your timezone](https://www.thetimezoneconverter.com/?t=8:00&tz=PT%20%28Pacific%20Time%29). | |||
* Tuesday at 08:00 Pacific Time (English)(biweekly). [Convert to your timezone](https://dateful.com/time-zone-converter?t=07:00&tz=PT%20%28Pacific%20Time%29). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tuesday at 08:00 Pacific Time (English)(biweekly)
--> "Tuesday at15:00 UTC+0
(English)(biweekly)"- This link seems more clear:
https://dateful.com/convert/coordinated-universal-time-utc?t=15
- Please help update the Chinese meeting timezone link to
https://dateful.com/convert/utc8?t=1430
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh ok, I'm making these changes and I'll let you know when I finish.
Signed-off-by: Gabriel Reis <[email protected]>
b3033b1
to
8f53065
Compare
@RainbowMango I made the corrections and sign the commits, see if was this. tks for the attention... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
Thank you!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #6030
Special notes for your reviewer:
Does this PR introduce a user-facing change?: