patch: modify test (#1076)

* patch: modify test

* patch: update view to return 404 as json

django_project/monitor/observation_views.py

@@ -32,7 +32,6 @@
 from rest_framework.viewsets import GenericViewSet
 from tensorflow import keras
 from django.contrib.auth.models import User
-from rest_framework.response import Response
 from rest_framework import status
 
 
@@ -60,11 +59,10 @@ def get_observations_by_site(request, site_id, format=None):
 		observations = Observations.objects.filter(site=site)
 		serializer = ObservationsAllFieldsSerializer(observations, many=True)
 
-		return JsonResponse(
-			{'status': 'success', 'observations': serializer.data}
-		)
-	except Sites.DoesNotExist:
-		raise Http404("Site does not exist")
+		return JsonResponse({'status': 'success', 'observations': serializer.data})
+
+	except Sites.DoesNotExist as e:
+		return JsonResponse({'status': 'error', 'message': 'Site does not exist'}, status=404)
 
 
 # Use environment variables for Minio configuration

django_project/monitor/tests/test_observations.py

@@ -440,13 +440,10 @@ def test_observations_by_site_id(self):
 		self.assertEqual(response['Content-Type'], 'application/json')
 
 	def test_observations_by_nonexistent_site_id(self):
-			self.client.login(email='[email protected]', password='testuserpassword')
-
-			url = reverse('observations-by-site', kwargs={'site_id': 999})
-
-			# Check if the Sites.DoesNotExist exception is raised
-			with self.assertRaises(Sites.DoesNotExist):
-				self.client.get(url)
+	        self.client.login(email='[email protected]', password='testuserpassword')
+	        url = reverse('observations-by-site', kwargs={'site_id': 999})
+	        response = self.client.get(url)
+	        self.assertEqual(response.status_code, 404)
 
 	def test_expert_auto_validated_observation(self):
 		"""