Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd party api update #1111

Merged
merged 4 commits into from
Oct 11, 2024
Merged

3rd party api update #1111

merged 4 commits into from
Oct 11, 2024

Conversation

ketankartoza
Copy link
Contributor

This PR is for the issue #1092

@ketankartoza ketankartoza added the Documentation Improvements or additions to documentation label Oct 9, 2024
@ketankartoza ketankartoza self-assigned this Oct 9, 2024
@EliVolsch
Copy link

Hi @ketankartoza I have reviewd and it's looking good however the links to Redoc and Sawgger are not correct. I see you have updated some of the images and all are now links which will provide a larger image, great job with that, and I believe the workflow for postman looks good.

Please change the following:
Line 214 - Link for Swagger: [here](https://minisass.org/swagger/) the ".com" is what was causing the issue.
Line 274 - Link for Redoc: [here](https://minisass.org/redoc/#tag/Sites-with-Observations) also the ".com" causing problems

@EliVolsch
Copy link

LGTM

@amyburness amyburness merged commit 7194c1c into main Oct 11, 2024
@lgkgh
Copy link
Collaborator

lgkgh commented Oct 11, 2024

Jenkins Build Details:

Build status: SUCCESS
Build duration: 2 min 6 sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants