Fix TAHMO ingestor for empty value (#18)

kartoza · Jul 3, 2024 · d461836 · d461836
1 parent a548ab9
commit d461836
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/django_project/gap/ingestor/tahmo.py b/django_project/gap/ingestor/tahmo.py
@@ -139,6 +139,11 @@ def _run(self, dir_path):
                                     unit = attr_var.unit
                                 except KeyError:
                                     unit = None
+
+                                # Skip empty one
+                                if value == '':
+                                    continue
+
                                 measure, _ = Measurement.objects.get_or_create(
                                     station=station,
                                     attribute=attribute,

diff --git a/django_project/gap/tests/ingestor/data/TAHMO test stations.zip b/django_project/gap/tests/ingestor/data/TAHMO test stations.zip
diff --git a/django_project/gap/tests/ingestor/test_tahmo.py b/django_project/gap/tests/ingestor/test_tahmo.py
@@ -69,5 +69,5 @@ def test_correct(self):
         ).measurement_set.all()
         for attribute in Attribute.objects.all():
             self.assertEqual(
-                measurements.filter(attribute=attribute).count(), 24
+                measurements.filter(attribute=attribute).count(), 23
             )