-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add message to sftp #359
base: main
Are you sure you want to change the base?
Add message to sftp #359
Conversation
@osundwajeff please move the sftp config into environment variables |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
==========================================
+ Coverage 93.64% 93.67% +0.02%
==========================================
Files 247 248 +1
Lines 13806 13879 +73
==========================================
+ Hits 12929 13001 +72
- Misses 877 878 +1 ☔ View full report in Codecov by Sentry. |
@@ -179,3 +193,55 @@ def _save_grid_data(self, df: pd.DataFrame): | |||
file_path = self.grid_data_file_path | |||
print(f'writing dataframe to {file_path}') | |||
df.to_parquet(file_path) | |||
|
|||
def _save_message_output_csv(self, df: dask_df): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you help to undo the change to produce csv?
I have created the function to export as csv.
https://github.com/kartoza/tomorrownow_gap/blob/main/django_project/dcas/outputs.py#L216
As of now, we don't have a detail for client's SFTP yet, so I will integrate _upload_to_sftp later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will undo that. Thanks @danangmassandy
WIP.
#310