Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message to sftp #359

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add message to sftp #359

wants to merge 5 commits into from

Conversation

osundwajeff
Copy link
Contributor

WIP.

#310

@danangmassandy
Copy link
Collaborator

@osundwajeff please move the sftp config into environment variables

Copy link

github-actions bot commented Jan 21, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
14335 13448 94% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 02c0c34 by action🐍

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 94.52055% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.67%. Comparing base (6eceb3a) to head (02c0c34).

Files with missing lines Patch % Lines
django_project/dcas/outputs.py 90.90% 3 Missing ⚠️
django_project/dcas/pipeline.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
+ Coverage   93.64%   93.67%   +0.02%     
==========================================
  Files         247      248       +1     
  Lines       13806    13879      +73     
==========================================
+ Hits        12929    13001      +72     
- Misses        877      878       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@osundwajeff osundwajeff marked this pull request as ready for review January 21, 2025 14:05
@@ -179,3 +193,55 @@ def _save_grid_data(self, df: pd.DataFrame):
file_path = self.grid_data_file_path
print(f'writing dataframe to {file_path}')
df.to_parquet(file_path)

def _save_message_output_csv(self, df: dask_df):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you help to undo the change to produce csv?
I have created the function to export as csv.
https://github.com/kartoza/tomorrownow_gap/blob/main/django_project/dcas/outputs.py#L216

As of now, we don't have a detail for client's SFTP yet, so I will integrate _upload_to_sftp later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will undo that. Thanks @danangmassandy

@mvmaltitz mvmaltitz linked an issue Jan 22, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DCAS: Generate and Send output to SFTP
2 participants