Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dcas error handling #385

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add dcas error handling #385

wants to merge 7 commits into from

Conversation

osundwajeff
Copy link
Contributor

@osundwajeff osundwajeff commented Jan 22, 2025

Fix: #317

Copy link

github-actions bot commented Jan 22, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
14571 13758 94% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: fea4a40 by action🐍

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.30%. Comparing base (ac6cc22) to head (fea4a40).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
+ Coverage   94.29%   94.30%   +0.01%     
==========================================
  Files         250      250              
  Lines       14087    14116      +29     
==========================================
+ Hits        13283    13312      +29     
  Misses        804      804              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@osundwajeff osundwajeff marked this pull request as ready for review January 23, 2025 23:15
@@ -92,6 +92,10 @@
# Run everyday at 00:15 UTC
'schedule': crontab(minute='15', hour='00'),
},
'log-farms-without-messages': {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@osundwajeff we can trigger the task right after pipeline (PR #373), so we don't need to make this as periodic task. Could you also change the task to receive request_id instead of request_date? Thank you,,

@danangmassandy
Copy link
Collaborator

danangmassandy commented Jan 24, 2025

@osundwajeff could you also add the export to csv/excel from the django admin page? maybe add it as another new ticket.

)

# Query farms without messages
df = DataQuery.get_farms_without_messages(parquet_path)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also do chunks query to avoid loading all the data into memory? it's to ensure the scalability when there are a lot of farms with missing messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DCAS: Error handling
2 participants