-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dcas error handling #385
base: main
Are you sure you want to change the base?
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
==========================================
+ Coverage 94.29% 94.30% +0.01%
==========================================
Files 250 250
Lines 14087 14116 +29
==========================================
+ Hits 13283 13312 +29
Misses 804 804 ☔ View full report in Codecov by Sentry. |
@@ -92,6 +92,10 @@ | |||
# Run everyday at 00:15 UTC | |||
'schedule': crontab(minute='15', hour='00'), | |||
}, | |||
'log-farms-without-messages': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@osundwajeff we can trigger the task right after pipeline (PR #373), so we don't need to make this as periodic task. Could you also change the task to receive request_id instead of request_date? Thank you,,
@osundwajeff could you also add the export to csv/excel from the django admin page? maybe add it as another new ticket. |
) | ||
|
||
# Query farms without messages | ||
df = DataQuery.get_farms_without_messages(parquet_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also do chunks query to avoid loading all the data into memory? it's to ensure the scalability when there are a lot of farms with missing messages
Fix: #317