Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notification to Admins for Ingestor Failure #387

Merged
merged 7 commits into from
Jan 27, 2025

Conversation

osundwajeff
Copy link
Contributor

Fix #321

Copy link

github-actions bot commented Jan 23, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
14808 13980 94% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 5a5c571 by action🐍

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 93.95349% with 13 lines in your changes missing coverage. Please review.

Project coverage is 94.29%. Comparing base (ac6cc22) to head (5a5c571).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
django_project/gap/tasks/collector.py 71.42% 10 Missing ⚠️
django_project/gap/tasks/ingestor.py 91.17% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main     #387    +/-   ##
========================================
  Coverage   94.29%   94.29%            
========================================
  Files         250      250            
  Lines       14087    14352   +265     
========================================
+ Hits        13283    13533   +250     
- Misses        804      819    +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

django_project/gap/tasks/ingestor.py Outdated Show resolved Hide resolved
django_project/core/celery.py Outdated Show resolved Hide resolved
django_project/gap/tasks/ingestor.py Show resolved Hide resolved
@danangmassandy danangmassandy merged commit d889276 into main Jan 27, 2025
4 checks passed
@danangmassandy danangmassandy deleted the feat-notification-ingestor-failure branch January 27, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should have notification if ingestor is failed
2 participants