Fix Space#moveWindows on Sonoma 14.5. #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 3, 2024
kasper
requested changes
Jun 7, 2024
There was a problem hiding this comment.
@metakirby5 Thank you for the help! ❤️ I added some comments, could you address them? Thanks!
kasper
reviewed
Jun 8, 2024
kasper
reviewed
Jun 8, 2024
kasper
reviewed
Jun 8, 2024
kasper
approved these changes
Jun 9, 2024
|
@kasper Thanks for approving! I don't have permission to merge, so can you do so for me? 🙏 |
|
@metakirby5 Thanks, merged! I will try to get this released soon. I want to update all the dependencies while at it. |
|
Just x-posing here, maybe it gets visible? 😅 |
|
@dan-phantom Hey, thanks for the ping! Let’s continue in #351. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a workaround to CGSMoveWindowsToManagedSpace breaking in MacOS 14.5, based on:
Fixes #348 and #349.