Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Tag Manager is not triggered in the new homepage #419

Closed
2 of 3 tasks
baraeb92 opened this issue Jul 25, 2021 · 5 comments · Fixed by #423
Closed
2 of 3 tasks

Google Tag Manager is not triggered in the new homepage #419

baraeb92 opened this issue Jul 25, 2021 · 5 comments · Fixed by #423
Assignees
@zainfathoni
Labels
bug Something isn't working good first issue Good for newcomers high-priority Issue with high priority need-perf-check Trigger Lighthouse-CI check
Milestone
Further Optimizat...

Comments

@baraeb92
Copy link
Collaborator

baraeb92 commented Jul 25, 2021 •
edited by zainfathoni
Loading

Description

Previous Google Tag Manager is no longer triggered in Warga Bantu Warga website after the homepage revamps, thus creating an issue where data is not sent to Google Analytics.

Expected Behaviour

Google Tag Manager should be triggered on every page, see the previous PR here: #36

Additional Information

  • Add the GTM trigger back to WBW
  • Add proper noscript implementation for Google Tag Manager in WBW
  • Add unit test to this critical functionality to ensure that future refactor will be less likely to produce the same bug, or later engineers will notice if this bug is recurring. Perhaps using React Test Library or Enzyme Testing for GTM #425

See the discussion thread here: Screen Shot 2021-07-25 at 22 31 49
@baraeb92 baraeb92 added the bug Something isn't working label Jul 25, 2021
@baraeb92 baraeb92 added this to the Further Optimizations milestone Jul 25, 2021
@zainfathoni zainfathoni added good first issue Good for newcomers need-perf-check Trigger Lighthouse-CI check labels Jul 25, 2021
@mazipan mazipan mentioned this issue Jul 25, 2021
Merged
3 tasks
@mazipan mazipan added the high-priority Issue with high priority label Jul 25, 2021
@mazipan mazipan mentioned this issue Jul 25, 2021
Open
@baraeb92 baraeb92 reopened this Jul 26, 2021
@baraeb92
Copy link
Collaborator Author

baraeb92 commented Jul 26, 2021 •
edited
Loading

Reopening this, to investigate the cause on why the noscript is not present on the when the web is loaded.

See my comment here: https://github.com/kawalcovid19/wargabantuwarga.com/pull/423/files/fd7d2157452ee2df2515a30d3d7c9494fc618f18#r676263160

@mazipan

@mazipan
Copy link
Member

mazipan commented Jul 26, 2021

Screen Shot 2021-07-26 at 10 50 41

@mazipan mazipan mentioned this issue Jul 26, 2021
Merged
2 tasks
@mazipan
Copy link
Member

mazipan commented Jul 26, 2021

We have issue #439

@mazipan
Copy link
Member

mazipan commented Jul 27, 2021

Can we close this @baraeb92?

@baraeb92
Copy link
Collaborator Author

Yes we can @mazipan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zainfathoni zainfathoni

Labels
bug Something isn't working good first issue Good for newcomers high-priority Issue with high priority need-perf-check Trigger Lighthouse-CI check
Projects
None yet
Milestone
Further Optimizations
Development

Successfully merging a pull request may close this issue.

revert: bring back gtm
3 participants
@zainfathoni @mazipan @baraeb92