-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gtm): move noscript under body #438
fix(gtm): move noscript under body #438
Conversation
✔️ Deploy Preview for wargabantuwarga ready! 🔨 Explore the source changes: 124dffd 🔍 Inspect the deploy log: https://app.netlify.com/sites/wargabantuwarga/deploys/60fe3bb7a5fd700007cde716 😎 Browse the preview: https://deploy-preview-438--wargabantuwarga.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #438 +/- ##
=======================================
Coverage 39.58% 39.58%
=======================================
Files 67 67
Lines 864 864
Branches 257 257
=======================================
Hits 342 342
Misses 516 516
Partials 6 6
Continue to review full report at Codecov.
|
What do you think, @resir014? |
I think we need to differentiate ya, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Thanks, Mas @mazipan! 🙏
Do not merge it now ya. |
Maybe try replacing my But remember not to put it in the |
@zainfathoni Yes, let's replace everything with |
Issue created: #439 |
Closes issue on #419
Description
Move GTM under the body
Current Tasks
noscript
from_app
to_document