-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add static slug for province detail page #361
feat: Add static slug for province detail page #361
Conversation
✔️ Deploy Preview for wargabantuwarga ready! 🔨 Explore the source changes: 5fe61d8 🔍 Inspect the deploy log: https://app.netlify.com/sites/wargabantuwarga/deploys/60fd79f351069000070fa1d9 😎 Browse the preview: https://deploy-preview-361--wargabantuwarga.netlify.app |
…to feat/provincee-static-slug
…bantuwarga.com into feat/provincee-static-slug
This PR is waiting for #313 to be resolved first, as slug generation depends on |
Codecov Report
@@ Coverage Diff @@
## main #361 +/- ##
==========================================
+ Coverage 25.34% 26.96% +1.62%
==========================================
Files 66 66
Lines 864 864
Branches 253 252 -1
==========================================
+ Hits 219 233 +14
+ Misses 641 627 -14
Partials 4 4
Continue to review full report at Codecov.
|
…to feat/provincee-static-slug
…bantuwarga.com into feat/provincee-static-slug
Please fix the CI checks, @Namchee, thanks! 🙏 |
…to feat/provincee-static-slug
@zainfathoni the netlify build will always fail since I added a new static property Can we make sure that the app fetches fresh data before any build? |
You can temporarily revert this line into using the I know it's a hassle, but I don't think we need to optimize this workflow, because #374 is coming soon anyway, and it will render both |
…bantuwarga.com into feat/provincee-static-slug
Side note: The test is really minimal, just to pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Thanks for working on it, @Namchee! 🙏
Closes #288
Description
Generate static slugs for all provinces and apply all related changes to the client side code.
Current Tasks