Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the websocket detection #105

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Fix the websocket detection #105

merged 1 commit into from
Jan 8, 2025

Conversation

palagdan
Copy link
Collaborator

Resolve #90
websocket_notification

@palagdan palagdan requested a review from blcham December 27, 2024 12:14
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I have 2 comments that should be resolved.

src/pages/ScriptPage.jsx Show resolved Hide resolved
src/pages/ScriptPage.jsx Show resolved Hide resolved
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment.

src/pages/ScriptPage.jsx Show resolved Hide resolved
@palagdan palagdan force-pushed the 90-websocket-detection branch from c418d8a to 15c83c8 Compare December 29, 2024 18:21
@palagdan palagdan requested a review from blcham December 29, 2024 18:22
@blcham blcham force-pushed the 90-websocket-detection branch from 15c83c8 to 054f87e Compare January 6, 2025 23:12
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@palagdan palagdan force-pushed the 90-websocket-detection branch from 054f87e to baf942f Compare January 8, 2025 16:02
@palagdan palagdan merged commit 8f03e57 into master Jan 8, 2025
2 checks passed
@palagdan palagdan deleted the 90-websocket-detection branch January 8, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix websocket to support script changes detection
2 participants