Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script execution #109

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Fix script execution #109

merged 1 commit into from
Feb 5, 2025

Conversation

palagdan
Copy link
Collaborator

@palagdan palagdan commented Dec 30, 2024

Resolve #96

I corrected the name of the repository, that is in the s-pipes-engine config.

@palagdan palagdan changed the title [#96] Fix script execution Fix script execution Dec 30, 2024
@blcham blcham force-pushed the 96-script-execution branch from db263a1 to 75b149f Compare January 6, 2025 22:50
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments (maybe discussion is needed)

Comment on lines 49 to 51
- /tmp:/tmp
- ${SHARED_ROOT:-/home}:${SHARED_ROOT:-/home}
- /usr/local/tomcat/temp/:/usr/local/tomcat/temp/
# - /usr/local/tomcat/temp/:/usr/local/tomcat/temp/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why u are commenting out this mapping. Maybe because it does not work in Windows? I guess same applies to /tmp right?

I suggest to add it as an extension .dev/dc-s-pipes-editor-rest--unify-paths-in-linux.yml, similar way as in record-manager-ui/deploy/.dev

Copy link
Collaborator Author

@palagdan palagdan Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blcham
I use Linux and encountered an issue with mounting the path /usr/local/tomcat/temp/. Every time I wanted to run docker-compose, I had to manually comment out
- /usr/local/tomcat/temp/:/usr/local/tomcat/temp/ . After investigating the problem, I discovered that my Docker installation was done via Snap, which caused this issue.

It might be a good idea to add a warning about this to the README. Here's a related discussion: https://stackoverflow.com/questions/45764477/docker-compose-error-while-creating-mount-source-path.

Or another solution #110 .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be solved in #116

@palagdan palagdan force-pushed the 96-script-execution branch from 75b149f to aff224f Compare January 8, 2025 16:09
@blcham blcham force-pushed the 96-script-execution branch from aff224f to 00c6af8 Compare February 3, 2025 14:29
@blcham
Copy link
Contributor

blcham commented Feb 3, 2025

@cipmo

@blcham blcham merged commit 310ee7b into master Feb 5, 2025
2 checks passed
@blcham blcham deleted the 96-script-execution branch February 5, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Script Execution Issues
2 participants