-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix script execution #109
Fix script execution #109
Conversation
db263a1
to
75b149f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comments (maybe discussion is needed)
deploy/docker-compose.yml
Outdated
- /tmp:/tmp | ||
- ${SHARED_ROOT:-/home}:${SHARED_ROOT:-/home} | ||
- /usr/local/tomcat/temp/:/usr/local/tomcat/temp/ | ||
# - /usr/local/tomcat/temp/:/usr/local/tomcat/temp/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why u are commenting out this mapping. Maybe because it does not work in Windows? I guess same applies to /tmp
right?
I suggest to add it as an extension .dev/dc-s-pipes-editor-rest--unify-paths-in-linux.yml
, similar way as in record-manager-ui/deploy/.dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blcham
I use Linux and encountered an issue with mounting the path /usr/local/tomcat/temp/
. Every time I wanted to run docker-compose, I had to manually comment out
- /usr/local/tomcat/temp/:/usr/local/tomcat/temp/
. After investigating the problem, I discovered that my Docker installation was done via Snap, which caused this issue.
It might be a good idea to add a warning about this to the README. Here's a related discussion: https://stackoverflow.com/questions/45764477/docker-compose-error-while-creating-mount-source-path.
Or another solution #110 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be solved in #116
75b149f
to
aff224f
Compare
aff224f
to
00c6af8
Compare
Resolve #96
I corrected the name of the repository, that is in the s-pipes-engine config.