-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor]: replace verbose completion tests with snapshot-based macro invocations #1780
base: main
Are you sure you want to change the base?
Conversation
44f37f7
to
4a32c48
Compare
Hi @SkySingh04 😄 The github action issue I have fixed in the main branch, try rebase main branch |
CI is broken now. Just wait for us to fix ci first. We will notify you when it is completed |
It looks like you didn't add the new snapshots file to git |
0fc8596
to
ccc3aa0
Compare
@He1pa The snapshots have been added! |
please fmt code |
5f68156
to
335876f
Compare
…invocations Signed-off-by: Akash <[email protected]>
335876f
to
1311466
Compare
Signed-off-by: Akash <[email protected]>
26655a0
to
48a349e
Compare
Signed-off-by: Akash <[email protected]>
Signed-off-by: Akash <[email protected]>
48a349e
to
c58cc84
Compare
Signed-off-by: Akash <[email protected]>
4230c73
to
54494e1
Compare
Hi @He1pa , I am a little confused about how to update the snapshots here. When i run and that I should update them using I'd be appreciate if someone could help on this issue. CC : @zong-zhe |
1. Does this PR affect any open issues?(Y/N) and add issue references:
fix [Refactor] refactor lsp tests #1374
2. What is the scope of this PR (e.g. component or file name):
/tools/src/LSP/src/completion.rs
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: