fixed infusionsoft version

keapgeek · Jul 19, 2024 · 7fd692e · 7fd692e
1 parent 96df82d
commit 7fd692e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 12 deletions.
diff --git a/src/ServiceFactory.php b/src/ServiceFactory.php
@@ -192,8 +192,8 @@ public function user()
         return new V1\User();
     }
 
-    public function submitForm(string $form_xid, array $data, array $headers = [])
+    public function submitForm(string $form_xid, string $infusionsoft_version, array $data, array $headers = [])
     {
-        return new Services\Form($form_xid, $data, $headers);
+        return new Services\Form($form_xid, $infusionsoft_version, $data, $headers);
     }
 }
diff --git a/src/Services/Form.php b/src/Services/Form.php
@@ -3,15 +3,17 @@
 namespace KeapGeek\Keap\Services;
 
 use Illuminate\Support\Facades\Http;
+use KeapGeek\Keap\Exceptions\KeapException;
 
 class Form
 {
-    public function __construct(string $form_xid, array $data, array $headers = [])
+    public function __construct(string $form_xid, string $infusionsoft_version, array $data, array $headers = [])
     {
         if (empty(config('keap.app_name'))) {
-            return;
+            throw new KeapException('App_name not set in configuration.');
         }
         $data['inf_form_xid'] = $form_xid;
+        $data['infusionsoft_version'] = $infusionsoft_version;
 
         Http::withHeaders($headers)->asForm()->post('https://'.config('keap.app_name').'.infusionsoft.com/app/form/process/'.$form_xid, $data);
     }

diff --git a/tests/Feature/FormTest.php b/tests/Feature/FormTest.php
@@ -2,6 +2,7 @@
 
 use Illuminate\Support\Facades\Config;
 use Illuminate\Support\Facades\Http;
+use KeapGeek\Keap\Exceptions\KeapException;
 use KeapGeek\Keap\Facades\Keap;
 use KeapGeek\Keap\Services\Form;
 
@@ -10,19 +11,15 @@
     Http::fake();
 });
 
-test('facade returns a Form Service', function () {
-    expect(Keap::submitForm('::xid::', []))->toBeInstanceOf(Form::class);
-});
 
-test('if config is not set no Http call', function () {
+test('if config is not set throws Exception', function () {
     Config::set('keap.app_name', null);
-    Keap::submitForm('::xid::', []);
-    Http::assertNothingSent();
-});
+    Keap::submitForm('::xid::', '1.2.3', []);
+})->throws(KeapException::class);
 
 test('if config is set it sends Http call', function () {
     Config::set('keap.app_name', 'aaa111');
-    Keap::submitForm('::xid::', []);
+    Keap::submitForm('::xid::', '1.2.3', []);
     Http::assertSent(function ($request) {
         return $request->url() === 'https://aaa111.infusionsoft.com/app/form/process/::xid::' &&
                $request->method() === 'POST';