Skip to content

Commit

Permalink
Merge pull request #328 from keel-hq/feature/helm_approvals_deadline
Browse files Browse the repository at this point in the history
fixed a problem with helm approvals not getting default deadline
  • Loading branch information
rusenask authored Dec 14, 2018
2 parents d0fc99c + 881962e commit ac6f5d4
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions provider/helm/approvals.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ func (p *Provider) isApproved(event *types.Event, plan *UpdatePlan) (bool, error
if err != nil {
if err == cache.ErrNotFound {

if plan.Config.ApprovalDeadline == 0 {
plan.Config.ApprovalDeadline = types.KeelApprovalDeadlineDefault
}

// creating new one
approval := &types.Approval{
Provider: types.ProviderTypeHelm,
Expand Down

0 comments on commit ac6f5d4

Please sign in to comment.