feat: allow multiple operators

[TAdev0]

• issue [feat] Multiple Operators #9
• follows contribution guide
• code change includes tests
• breaking change

This PR allows the Core contract to register multiple operators.

[TAdev0]

@glihm hey :)

This is a first draft!
I used a legacyMap as specified, but i think my implementation is not optimized.

Indeed, get_operator is more like a is_operator function, returning true if the address passed to the function is an operator.
Maybe should we use some array to store all operators in the contract?

[glihm]

@glihm hey :)

This is a first draft! I used a legacyMap as specified, but i think my implementation is not optimized.

Indeed, get_operator is more like a is_operator function, returning true if the address passed to the function is an operator. Maybe should we use some array to store all operators in the contract?

Hey, thanks for the progress!
Hum, actually the very first objective of the hashmap is to check. So we're totally right and The solidity code is actually using is_operator so you can totally rename. 👍
They are also using register_operator instead of set_operator. You can also rename it will be better.

Those names was because the first impl didn't add the support for multiple operators. 👍

[glihm]

Will wait the renaming for other review, good progress. 👍

[TAdev0]

@glihm PR updated :)

[glihm]

Some minor comment on formatting, and we should be good to go!

[TAdev0]

@glihm PR updated !
I changed the error message in tests for "expect not operator". Tell me if you prefer something else, like "operator already registered" ..

[b-j-roberts]

I left a couple of things, thank you!

[TAdev0]

hi @b-j-roberts , i just updated the PR. I also added a check for both the register and unregister functions, and added a test for the unregister function.
Tell me if this is ok for you.

[b-j-roberts]

Great work! Thank you.