Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: Book Buildout #19

Merged
merged 8 commits into from
Mar 12, 2024
Merged

dev: Book Buildout #19

merged 8 commits into from
Mar 12, 2024

Conversation

JimmyFate
Copy link
Contributor

@JimmyFate JimmyFate commented Feb 22, 2024 •
edited
Loading

Changes

  • added initial mdbook
image

@JimmyFate JimmyFate marked this pull request as ready for review February 22, 2024 22:35
@JimmyFate
Copy link
Contributor Author

JimmyFate commented Mar 9, 2024 •
edited
Loading

@b-j-roberts Any chance to have this looked at? 👀

b-j-roberts
b-j-roberts requested changes Mar 11, 2024
View reviewed changes
book/src/README.md Show resolved Hide resolved
@JimmyFate JimmyFate requested a review from b-j-roberts March 12, 2024 00:06
b-j-roberts
b-j-roberts approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@b-j-roberts b-j-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@b-j-roberts b-j-roberts merged commit 5f9403b into keep-starknet-strange:main Mar 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-j-roberts b-j-roberts b-j-roberts approved these changes

@drspacemn drspacemn Awaiting requested review from drspacemn

@glihm glihm Awaiting requested review from glihm glihm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JimmyFate @b-j-roberts